tools/json_schema_compiler/test/objects_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/objects_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/objects_unittest.cc

diff --git a/tools/json_schema_compiler/test/objects_unittest.cc b/tools/json_schema_compiler/test/objects_unittest.cc

index 485e1d6055ea74eff66b21d79db4f0a9c6a79394..a24ca3b6117b44a3e02d6de538733b6c1331f702 100644

--- a/tools/json_schema_compiler/test/objects_unittest.cc

+++ b/tools/json_schema_compiler/test/objects_unittest.cc

@@ -17,7 +17,7 @@ TEST(JsonSchemaCompilerObjectsTest, ObjectParamParamsCreate) {

scoped_ptr<base::DictionaryValue> info_value(new base::DictionaryValue());

info_value->Set("strings", strings.release());

info_value->Set("integer", new base::FundamentalValue(5));

- info_value->Set("boolean", base::Value::CreateBooleanValue(true));

+ info_value->Set("boolean", new base::FundamentalValue(true));

scoped_ptr<base::ListValue> params_value(new base::ListValue());

params_value->Append(info_value.release());