Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Side by Side Diff: chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/prefs/pref_value_map.h" 7 #include "base/prefs/pref_value_map.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/browser/net/disk_cache_dir_policy_handler.h" 9 #include "chrome/browser/net/disk_cache_dir_policy_handler.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
(...skipping 13 matching lines...) Expand all
24 TEST_F(DiskCacheDirPolicyTest, Default) { 24 TEST_F(DiskCacheDirPolicyTest, Default) {
25 handler_.ApplyPolicySettings(policy_, &prefs_); 25 handler_.ApplyPolicySettings(policy_, &prefs_);
26 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL)); 26 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
27 } 27 }
28 28
29 TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) { 29 TEST_F(DiskCacheDirPolicyTest, SetPolicyInvalid) {
30 // DiskCacheDir policy expects a string; give it a boolean. 30 // DiskCacheDir policy expects a string; give it a boolean.
31 policy_.Set(key::kDiskCacheDir, 31 policy_.Set(key::kDiskCacheDir,
32 POLICY_LEVEL_MANDATORY, 32 POLICY_LEVEL_MANDATORY,
33 POLICY_SCOPE_USER, 33 POLICY_SCOPE_USER,
34 base::Value::CreateBooleanValue(false), 34 new base::FundamentalValue(false),
35 NULL); 35 NULL);
36 handler_.ApplyPolicySettings(policy_, &prefs_); 36 handler_.ApplyPolicySettings(policy_, &prefs_);
37 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL)); 37 EXPECT_FALSE(prefs_.GetValue(prefs::kDiskCacheDir, NULL));
38 } 38 }
39 39
40 TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) { 40 TEST_F(DiskCacheDirPolicyTest, SetPolicyValid) {
41 // Use a variable in the value. It should be expanded by the handler. 41 // Use a variable in the value. It should be expanded by the handler.
42 const std::string in = "${user_name}/foo"; 42 const std::string in = "${user_name}/foo";
43 policy_.Set(key::kDiskCacheDir, 43 policy_.Set(key::kDiskCacheDir,
44 POLICY_LEVEL_MANDATORY, 44 POLICY_LEVEL_MANDATORY,
45 POLICY_SCOPE_USER, 45 POLICY_SCOPE_USER,
46 base::Value::CreateStringValue(in), 46 base::Value::CreateStringValue(in),
47 NULL); 47 NULL);
48 handler_.ApplyPolicySettings(policy_, &prefs_); 48 handler_.ApplyPolicySettings(policy_, &prefs_);
49 49
50 const base::Value* value; 50 const base::Value* value;
51 ASSERT_TRUE(prefs_.GetValue(prefs::kDiskCacheDir, &value)); 51 ASSERT_TRUE(prefs_.GetValue(prefs::kDiskCacheDir, &value));
52 std::string out; 52 std::string out;
53 ASSERT_TRUE(value->GetAsString(&out)); 53 ASSERT_TRUE(value->GetAsString(&out));
54 EXPECT_NE(std::string::npos, out.find("foo")); 54 EXPECT_NE(std::string::npos, out.find("foo"));
55 EXPECT_EQ(std::string::npos, out.find("${user_name}")); 55 EXPECT_EQ(std::string::npos, out.find("${user_name}"));
56 } 56 }
57 57
58 } // namespace policy 58 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/download/download_query_unittest.cc ('k') | chrome/browser/policy/cloud/cloud_policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698