tools/json_schema_compiler/test/arrays_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/arrays_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/arrays_unittest.cc

diff --git a/tools/json_schema_compiler/test/arrays_unittest.cc b/tools/json_schema_compiler/test/arrays_unittest.cc

index 204f81aa80d39c6c0f0bb6b3fd42c05362f5facd..ea252440b8c2b2f444e65027352a14a510b83bfc 100644

--- a/tools/json_schema_compiler/test/arrays_unittest.cc

+++ b/tools/json_schema_compiler/test/arrays_unittest.cc

@@ -24,8 +24,8 @@ static scoped_ptr<base::DictionaryValue> CreateBasicArrayTypeDictionary() {

integers_value->Append(new base::FundamentalValue(2));

integers_value->Append(new base::FundamentalValue(3));

base::ListValue* booleans_value = new base::ListValue();

- booleans_value->Append(base::Value::CreateBooleanValue(false));

- booleans_value->Append(base::Value::CreateBooleanValue(true));

+ booleans_value->Append(new base::FundamentalValue(false));

+ booleans_value->Append(new base::FundamentalValue(true));

base::ListValue* numbers_value = new base::ListValue();

numbers_value->Append(base::Value::CreateDoubleValue(6.1));

value->Set("numbers", numbers_value);