Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc
diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
index 5e516b7eb38b713bfa4269a060126e987c115b4c..e307f98006c650729291767745fa192385ed4283 100644
--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
@@ -106,8 +106,11 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, GetDefault) {
TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
PolicyMap policy;
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false), NULL);
+ policy.Set(kTestPolicy,
+ POLICY_LEVEL_MANDATORY,
+ POLICY_SCOPE_USER,
+ new base::FundamentalValue(false),
+ NULL);
UpdateProviderPolicy(policy);
const base::Value* value = NULL;
EXPECT_TRUE(store_->GetValue(kTestPref, &value));
@@ -117,8 +120,11 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
ASSERT_TRUE(result);
EXPECT_FALSE(boolean_value);
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL);
+ policy.Set(kTestPolicy,
+ POLICY_LEVEL_MANDATORY,
+ POLICY_SCOPE_USER,
+ new base::FundamentalValue(true),
+ NULL);
UpdateProviderPolicy(policy);
value = NULL;
EXPECT_TRUE(store_->GetValue(kTestPref, &value));

Powered by Google App Engine
This is Rietveld 408576698