chrome/browser/download/download_query_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_query_unittest.cc

diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc

index a11446bb20c6440ed4654209022b30c5b869e4d0..c8f5330b5f805af8c6fc5c59cb45c49d428bb024 100644

--- a/chrome/browser/download/download_query_unittest.cc

+++ b/chrome/browser/download/download_query_unittest.cc

@@ -100,7 +100,7 @@ class DownloadQueryTest : public testing::Test {

template<> void DownloadQueryTest::AddFilter(

DownloadQuery::FilterType name, bool cpp_value) {

- scoped_ptr<base::Value> value(base::Value::CreateBooleanValue(cpp_value));

+ scoped_ptr<base::Value> value(new base::FundamentalValue(cpp_value));

CHECK(query_.AddFilter(name, *value.get()));

}