chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

index f14bf6c6b08d3ff5cabe00bb20a43cd4f981ef60..8a0aa91939a0e908ad101bda14caf5c8c8144297 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

@@ -277,7 +277,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) {

prefs->SetUserPref(prefs::kCloudPrintEmail,

base::Value::CreateStringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

service.Initialize();

@@ -295,7 +295,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) {

prefs->SetUserPref(prefs::kCloudPrintEmail,

base::Value::CreateStringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

service.Initialize();

@@ -318,7 +318,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) {

EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));

}

@@ -341,7 +341,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) {

service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));

}

@@ -357,7 +357,7 @@ TEST_F(CloudPrintProxyPolicyTest,

prefs->SetUserPref(prefs::kCloudPrintEmail,

base::Value::CreateStringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

service.Initialize();

@@ -378,7 +378,7 @@ TEST_F(CloudPrintProxyPolicyTest,

prefs->SetUserPref(prefs::kCloudPrintEmail,

base::Value::CreateStringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

service.Initialize();

@@ -420,7 +420,7 @@ TEST_F(CloudPrintProxyPolicyTest,

prefs->SetUserPref(prefs::kCloudPrintEmail,

base::Value::CreateStringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

service.Initialize();

@@ -456,7 +456,7 @@ TEST_F(CloudPrintProxyPolicyTest, StartupBrowserCreatorWithCommandLine) {

prefs->SetUserPref(prefs::kCloudPrintEmail,

base::Value::CreateStringValue(std::string()));

prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

CloudPrintProxyServiceFactory::GetInstance()->

SetTestingFactory(&profile_, TestCloudPrintProxyServiceFactory);