Eliminate CreateBooleanValue from test files

chrome/browser/chromeos/settings/cros_settings_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <string>
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 88 matching lines @@
   ScopedDeviceSettingsTestHelper device_settings_test_helper_;
   CrosSettings settings_;
 
   base::WeakPtrFactory<CrosSettingsTest> weak_factory_;
 
   std::map<std::string, base::Value*> expected_props_;
 };
 
 TEST_F(CrosSettingsTest, SetPref) {
   // Change to something that is not the default.
-  AddExpectation(kAccountsPrefAllowGuest,
-                 base::Value::CreateBooleanValue(false));
+  AddExpectation(kAccountsPrefAllowGuest, new base::FundamentalValue(false));
   SetPref(kAccountsPrefAllowGuest, expected_props_[kAccountsPrefAllowGuest]);
   FetchPref(kAccountsPrefAllowGuest);
   ASSERT_TRUE(expected_props_.empty());
 }
 
 TEST_F(CrosSettingsTest, GetPref) {
   // We didn't change the default so look for it.
-  AddExpectation(kAccountsPrefAllowGuest,
-                 base::Value::CreateBooleanValue(true));
+  AddExpectation(kAccountsPrefAllowGuest, new base::FundamentalValue(true));
   FetchPref(kAccountsPrefAllowGuest);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelist) {
   // Setting the whitelist should also switch the value of
   // kAccountsPrefAllowNewUser to false.
   base::ListValue whitelist;
   whitelist.Append(new base::StringValue("me@owner"));
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(false));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
   SetPref(kAccountsPrefUsers, &whitelist);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelistWithListOps) {
   base::ListValue* whitelist = new base::ListValue();
   base::StringValue hacky_user("h@xxor");
   whitelist->Append(hacky_user.DeepCopy());
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(false));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   AddExpectation(kAccountsPrefUsers, whitelist);
   // Add some user to the whitelist.
   settings_.AppendToList(kAccountsPrefUsers, &hacky_user);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelistWithListOps2) {
   base::ListValue whitelist;
   base::StringValue hacky_user("h@xxor");
   base::StringValue lamy_user("l@mer");
   whitelist.Append(hacky_user.DeepCopy());
   base::ListValue* expected_list = whitelist.DeepCopy();
   whitelist.Append(lamy_user.DeepCopy());
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(false));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
   SetPref(kAccountsPrefUsers, &whitelist);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
   ASSERT_TRUE(expected_props_.empty());
   // Now try to remove one element from that list.
   AddExpectation(kAccountsPrefUsers, expected_list);
   settings_.RemoveFromList(kAccountsPrefUsers, &lamy_user);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetEmptyWhitelist) {
   // Setting the whitelist empty should switch the value of
   // kAccountsPrefAllowNewUser to true.
   base::ListValue whitelist;
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(true));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(true));
   SetPref(kAccountsPrefUsers, &whitelist);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetEmptyWhitelistAndNoNewUsers) {
   // Setting the whitelist empty and disallowing new users should result in no
   // new users allowed.
   base::ListValue whitelist;
   base::FundamentalValue disallow_new(false);
   AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(false));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   SetPref(kAccountsPrefUsers, &whitelist);
   SetPref(kAccountsPrefAllowNewUser, &disallow_new);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelistAndNoNewUsers) {
   // Setting the whitelist should allow us to set kAccountsPrefAllowNewUser to
   // false (which is the implicit value too).
   base::ListValue whitelist;
   whitelist.Append(new base::StringValue("me@owner"));
   AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(false));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   SetPref(kAccountsPrefUsers, &whitelist);
   SetPref(kAccountsPrefAllowNewUser,
           expected_props_[kAccountsPrefAllowNewUser]);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetAllowNewUsers) {
   // Setting kAccountsPrefAllowNewUser to true with no whitelist should be ok.
-  AddExpectation(kAccountsPrefAllowNewUser,
-                 base::Value::CreateBooleanValue(true));
+  AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(true));
   SetPref(kAccountsPrefAllowNewUser,
           expected_props_[kAccountsPrefAllowNewUser]);
   FetchPref(kAccountsPrefAllowNewUser);
 }
 
 TEST_F(CrosSettingsTest, SetEphemeralUsersEnabled) {
   base::FundamentalValue ephemeral_users_enabled(true);
   AddExpectation(kAccountsPrefEphemeralUsersEnabled,
-                 base::Value::CreateBooleanValue(true));
+                 new base::FundamentalValue(true));
   SetPref(kAccountsPrefEphemeralUsersEnabled, &ephemeral_users_enabled);
   FetchPref(kAccountsPrefEphemeralUsersEnabled);
 }
 
 TEST_F(CrosSettingsTest, FindEmailInList) {
   base::ListValue list;
   list.Append(new base::StringValue("user@example.com"));
   list.Append(new base::StringValue("nodomain"));
   list.Append(new base::StringValue("with.dots@gmail.com"));
   list.Append(new base::StringValue("Upper@example.com"));
@@ skipping 36 matching lines @@
   EXPECT_TRUE(wildcard_match);
   EXPECT_TRUE(cs->FindEmailInList(
       kAccountsPrefUsers, "user@example.com", &wildcard_match));
   EXPECT_FALSE(wildcard_match);
   EXPECT_TRUE(cs->FindEmailInList(
       kAccountsPrefUsers, "*@example.com", &wildcard_match));
   EXPECT_TRUE(wildcard_match);
 }
 
 }  // namespace chromeos