Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Side by Side Diff: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_value_map.h" 5 #include "base/prefs/pref_value_map.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h" 7 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h"
8 #include "chrome/common/pref_names.h" 8 #include "chrome/common/pref_names.h"
9 #include "components/policy/core/common/policy_map.h" 9 #include "components/policy/core/common/policy_map.h"
10 #include "policy/policy_constants.h" 10 #include "policy/policy_constants.h"
(...skipping 12 matching lines...) Expand all
23 23
24 TEST_F(FileSelectionDialogsPolicyTest, Default) { 24 TEST_F(FileSelectionDialogsPolicyTest, Default) {
25 handler_.ApplyPolicySettings(policy_, &prefs_); 25 handler_.ApplyPolicySettings(policy_, &prefs_);
26 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL)); 26 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL));
27 } 27 }
28 28
29 TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) { 29 TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {
30 policy_.Set(key::kAllowFileSelectionDialogs, 30 policy_.Set(key::kAllowFileSelectionDialogs,
31 POLICY_LEVEL_MANDATORY, 31 POLICY_LEVEL_MANDATORY,
32 POLICY_SCOPE_USER, 32 POLICY_SCOPE_USER,
33 base::Value::CreateBooleanValue(true), 33 new base::FundamentalValue(true),
34 NULL); 34 NULL);
35 handler_.ApplyPolicySettings(policy_, &prefs_); 35 handler_.ApplyPolicySettings(policy_, &prefs_);
36 36
37 // Allowing file-selection dialogs should not influence the PromptForDownload 37 // Allowing file-selection dialogs should not influence the PromptForDownload
38 // pref. 38 // pref.
39 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL)); 39 EXPECT_FALSE(prefs_.GetValue(prefs::kPromptForDownload, NULL));
40 } 40 }
41 41
42 TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) { 42 TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) {
43 policy_.Set(key::kAllowFileSelectionDialogs, 43 policy_.Set(key::kAllowFileSelectionDialogs,
44 POLICY_LEVEL_MANDATORY, 44 POLICY_LEVEL_MANDATORY,
45 POLICY_SCOPE_USER, 45 POLICY_SCOPE_USER,
46 base::Value::CreateBooleanValue(false), 46 new base::FundamentalValue(false),
47 NULL); 47 NULL);
48 handler_.ApplyPolicySettings(policy_, &prefs_); 48 handler_.ApplyPolicySettings(policy_, &prefs_);
49 49
50 // Disabling file-selection dialogs should disable the PromptForDownload pref. 50 // Disabling file-selection dialogs should disable the PromptForDownload pref.
51 const base::Value* value = NULL; 51 const base::Value* value = NULL;
52 EXPECT_TRUE(prefs_.GetValue(prefs::kPromptForDownload, &value)); 52 EXPECT_TRUE(prefs_.GetValue(prefs::kPromptForDownload, &value));
53 ASSERT_TRUE(value); 53 ASSERT_TRUE(value);
54 bool prompt_for_download = true; 54 bool prompt_for_download = true;
55 bool result = value->GetAsBoolean(&prompt_for_download); 55 bool result = value->GetAsBoolean(&prompt_for_download);
56 EXPECT_TRUE(result); 56 EXPECT_TRUE(result);
57 EXPECT_FALSE(prompt_for_download); 57 EXPECT_FALSE(prompt_for_download);
58 } 58 }
59 59
60 } // namespace policy 60 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/policy/cloud/cloud_policy_browsertest.cc ('k') | chrome/browser/policy/javascript_policy_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698