chrome/browser/ui/webui/sync_internals_ui_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_internals_ui_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/sync_internals_ui_unittest.cc

diff --git a/chrome/browser/ui/webui/sync_internals_ui_unittest.cc b/chrome/browser/ui/webui/sync_internals_ui_unittest.cc

index 1d58505606bedb2d22eed96ac2ea01972137090a..5abfa19196711c450c42348c796af03f698e3ea0 100644

--- a/chrome/browser/ui/webui/sync_internals_ui_unittest.cc

+++ b/chrome/browser/ui/webui/sync_internals_ui_unittest.cc

@@ -123,7 +123,7 @@ TEST_F(SyncInternalsUITestWithService, HandleJsReply) {

base::ListValue args;

args.Append(base::Value::CreateIntegerValue(5));

- args.Append(base::Value::CreateBooleanValue(true));

+ args.Append(new base::FundamentalValue(true));

sync_internals_ui_->HandleJsReply("testMessage", JsArgList(&args));

}

@@ -189,7 +189,7 @@ TEST_F(SyncInternalsUITestWithoutService, HandleJsReply) {

base::ListValue args;

args.Append(base::Value::CreateIntegerValue(5));

- args.Append(base::Value::CreateBooleanValue(true));

+ args.Append(new base::FundamentalValue(true));

sync_internals_ui_->HandleJsReply(

"testMessage", JsArgList(&args));

}