chromeos: Move //ash/common/strings to //ash/strings

chromeos: Move //ash/common/strings to //ash/strings

Now that mustash uses aura we don't need the ash/mus vs. ash/aura vs.
ash/common distinction anymore. This is preparation for moving the rest
of the files in //ash/common out to //ash.

BUG=690096
TEST=compiles, ash_unittests, manually spot check some strings
TBR=reveman@chromium.org for exo

Review-Url: https://codereview.chromium.org/2725903003
Cr-Commit-Position: refs/heads/master@{#454282}
Committed: https://chromium.googlesource.com/chromium/src/+/e45f811e740dabbc0021e6d4a37b3648d8503f96

[James Cook, 2017-03-01 23:32:48]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:33:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-01 23:34:30]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2017-03-01 23:34:32]

msw, please take a look.

The header/cc file changes were all mechanical using
tools/git/move_source_files.py. The translation xtb files were git mv, and the
build files were a find/replace of "ash/common/strings" and a git cl format.

[msw, 2017-03-02 00:14:52]

lgtm with one comment and a request to check for similar mentions.
(I only spot-checked the cc and txb files, but that seems sufficient)

https://codereview.chromium.org/2725903003/diff/10001/chrome/tools/build/repa...
File chrome/tools/build/repack_locales.py (right):

https://codereview.chromium.org/2725903003/diff/10001/chrome/tools/build/repa...
chrome/tools/build/repack_locales.py:102:
inputs.append(os.path.join(SHARE_INT_DIR, 'ash', 'common', 'strings',
Fix this use of 'common', do a git gs/grep for something like
ash.*common.*strings

[James Cook, 2017-03-02 00:31:00]

https://codereview.chromium.org/2725903003/diff/10001/chrome/tools/build/repa...
File chrome/tools/build/repack_locales.py (right):

https://codereview.chromium.org/2725903003/diff/10001/chrome/tools/build/repa...
chrome/tools/build/repack_locales.py:102:
inputs.append(os.path.join(SHARE_INT_DIR, 'ash', 'common', 'strings',
On 2017/03/02 00:14:52, msw wrote:
> Fix this use of 'common', do a git gs/grep for something like
> ash.*common.*strings

Wow, good catch. Done, and after that the grep is clean.

[James Cook, 2017-03-02 00:40:55]

jamescook@chromium.org changed reviewers:
+ achuith@chromium.org, mmoss@chromium.org

[James Cook, 2017-03-02 00:40:56]

mmoss, can I get OWNERS for 	chrome/tools/build/repack_locales.py ?

achuith, can I get OWNERS for chrome/browser/chromeos ?

[James Cook, 2017-03-02 00:41:09]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 00:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Moss, 2017-03-02 00:44:00]

lgtm

[achuithb, 2017-03-02 00:44:47]

On 2017/03/02 00:40:56, James Cook wrote:
> mmoss, can I get OWNERS for 	chrome/tools/build/repack_locales.py ?
> 
> achuith, can I get OWNERS for chrome/browser/chromeos ?

lgtm for c/b/cros

[James Cook, 2017-03-02 00:51:19]

Description was changed from

==========
chromeos: Move //ash/common/strings to //ash/strings

Now that mustash uses aura we don't need the ash/mus vs. ash/aura vs.
ash/common distinction anymore. This is preparation for moving the rest
of the files in //ash/common out to //ash.

BUG=690096
TEST=compiles, ash_unittests, manually spot check some strings
==========

to

==========
chromeos: Move //ash/common/strings to //ash/strings

Now that mustash uses aura we don't need the ash/mus vs. ash/aura vs.
ash/common distinction anymore. This is preparation for moving the rest
of the files in //ash/common out to //ash.

BUG=690096
TEST=compiles, ash_unittests, manually spot check some strings
TBR=reveman@chromium.org for exo
==========

[James Cook, 2017-03-02 00:51:56]

TBR reveman for one-line rename in exo/BUILD.gn

[James Cook, 2017-03-02 00:52:26]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-03-02 00:52:35]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-03-02 00:52:36]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2725903003/#ps20001
(title: "fix repack locales")

[commit-bot: I haz the power, 2017-03-02 00:53:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 02:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 02:11:28]

Failed to apply patch for ash/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: ash/BUILD.gn:1391
  error: ash/BUILD.gn: patch does not apply

Patch:       ash/BUILD.gn
Index: ash/BUILD.gn
diff --git a/ash/BUILD.gn b/ash/BUILD.gn
index
d0216157d654e1c6b6400fdb37214ef7d6a94697..786ce232be3af1a9051d680f9a6d6e7e75a1dbd1
100644
--- a/ash/BUILD.gn
+++ b/ash/BUILD.gn
@@ -841,10 +841,10 @@ component("ash") {
   defines = [ "ASH_IMPLEMENTATION" ]
 
   public_deps = [
-    "//ash/common/strings",
     "//ash/resources",
     "//ash/resources/vector_icons",
     "//ash/shared:app_types",
+    "//ash/strings",
   ]
   deps = [
     "//ash/autoclick/common:autoclick",
@@ -1145,7 +1145,7 @@ test("ash_content_unittests") {
   ]
 
   data_deps = [
-    "//ash/common/strings:ash_test_strings",
+    "//ash/strings:ash_test_strings",
     "//ash/resources:ash_test_resources_with_content_100_percent",
     "//ash/resources:ash_test_resources_200_percent",
   ]
@@ -1391,12 +1391,12 @@ test("ash_unittests") {
     ":ash",
     ":common_unittests",
     "//ash/autoclick/common:autoclick",
-    "//ash/common/strings",
     "//ash/common/test:test_support",
     "//ash/public/cpp:ash_public_cpp",
     "//ash/public/interfaces",
     "//ash/resources",
     "//ash/resources/vector_icons",
+    "//ash/strings",
     "//ash/test:ash_with_aura_test_support",
     "//ash/test:test_support_without_content",
     "//ash/touch_hud",
@@ -1449,7 +1449,7 @@ test("ash_unittests") {
   ]
 
   data_deps = [
-    "//ash/common/strings:ash_test_strings",
+    "//ash/strings:ash_test_strings",
     "//ash/resources:ash_test_resources_100_percent",
     "//ash/resources:ash_test_resources_200_percent",
   ]
@@ -1483,7 +1483,7 @@ executable("ash_shell_with_content") {
   ]
 
   data_deps = [
-    "//ash/common/strings:ash_test_strings",
+    "//ash/strings:ash_test_strings",
     "//ash/resources:ash_test_resources_with_content_100_percent",
     "//ash/resources:ash_test_resources_200_percent",
   ]

[James Cook, 2017-03-02 03:09:39]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-03-02 03:09:40]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
achuith@chromium.org, mmoss@chromium.org
Link to the patchset: https://codereview.chromium.org/2725903003/#ps30001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-02 03:11:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 05:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 05:41:23]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[James Cook, 2017-03-02 15:01:15]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-03-02 15:01:16]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
achuith@chromium.org, mmoss@chromium.org
Link to the patchset: https://codereview.chromium.org/2725903003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-02 15:01:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 16:45:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488466875625260,
"parent_rev": "9a97d2d1d08b39636a0a6c014ff06320a78f1375", "commit_rev":
"e45f811e740dabbc0021e6d4a37b3648d8503f96"}

[commit-bot: I haz the power, 2017-03-02 16:46:28]

Description was changed from

==========
chromeos: Move //ash/common/strings to //ash/strings

Now that mustash uses aura we don't need the ash/mus vs. ash/aura vs.
ash/common distinction anymore. This is preparation for moving the rest
of the files in //ash/common out to //ash.

BUG=690096
TEST=compiles, ash_unittests, manually spot check some strings
TBR=reveman@chromium.org for exo
==========

to

==========
chromeos: Move //ash/common/strings to //ash/strings

Now that mustash uses aura we don't need the ash/mus vs. ash/aura vs.
ash/common distinction anymore. This is preparation for moving the rest
of the files in //ash/common out to //ash.

BUG=690096
TEST=compiles, ash_unittests, manually spot check some strings
TBR=reveman@chromium.org for exo

Review-Url: https://codereview.chromium.org/2725903003
Cr-Commit-Position: refs/heads/master@{#454282}
Committed:
https://chromium.googlesource.com/chromium/src/+/e45f811e740dabbc0021e6d4a37b...
==========

[commit-bot: I haz the power, 2017-03-02 16:46:30]

Committed patchset #5 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e45f811e740dabbc0021e6d4a37b...