Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
CC:
aboxhall+watch_chromium.org, achuith+watch_chromium.org, asanka, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, danakj, davemoore+watch_chromium.org, dbeam+watch-options_chromium.org, David Black, dhollowa+watch_chromium.org, dmazzoni+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, dtseng+watch_chromium.org, dzhioev+watch_chromium.org, extensions-reviews_chromium.org, je_julie, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, michaelpg+watch-options_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, stevenjb+watch_chromium.org, sync-reviews_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry BUG=581865 Committed: https://crrev.com/3b344bc2793161243e2718cc02a311143440396f Cr-Commit-Position: refs/heads/master@{#392521}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 5

Patch Set 4 : One more mac compile. #

Patch Set 5 : More fixes (partial Windows fix) #

Total comments: 4

Patch Set 6 : Fix Windows #

Patch Set 7 : . #

Patch Set 8 : . #

Total comments: 1

Patch Set 9 : Rebase and build fix #

Patch Set 10 : Windows... #

Patch Set 11 : another-fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2005 lines, -3218 lines) Patch
M chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc View 9 chunks +46 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc View 1 4 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc View 17 chunks +47 lines, -86 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 3 chunks +17 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 4 chunks +27 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 2 3 4 5 6 7 8 24 chunks +311 lines, -439 lines 0 comments Download
M chrome/browser/chromeos/policy/login_profile_policy_provider.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 8 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +16 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/download/download_dir_policy_handler_unittest.cc View 4 chunks +20 lines, -31 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc View 6 chunks +14 lines, -35 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_management_test_util.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/policy_handlers_unittest.cc View 14 chunks +47 lines, -110 lines 0 comments Download
M chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 chunk +40 lines, -82 lines 0 comments Download
M chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/policy/javascript_policy_handler_unittest.cc View 2 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc View 8 chunks +22 lines, -36 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 84 chunks +329 lines, -530 lines 0 comments Download
M chrome/browser/policy/policy_network_browsertest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/policy/policy_startup_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/policy/profile_policy_connector_unittest.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 5 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M chrome/browser/search/contextual_search_policy_handler_android_unittest.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc View 12 chunks +35 lines, -29 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 2 chunks +20 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui_handler.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M components/policy/core/browser/android/policy_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/autofill_policy_handler_unittest.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M components/policy/core/browser/configuration_policy_handler_unittest.cc View 14 chunks +90 lines, -212 lines 0 comments Download
M components/policy/core/browser/configuration_policy_pref_store_unittest.cc View 1 2 3 4 5 7 chunks +16 lines, -27 lines 0 comments Download
M components/policy/core/browser/proxy_policy_handler_unittest.cc View 14 chunks +98 lines, -145 lines 0 comments Download
M components/policy/core/browser/url_blacklist_policy_handler_unittest.cc View 12 chunks +26 lines, -20 lines 0 comments Download
M components/policy/core/common/async_policy_provider_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_manager_unittest.cc View 3 chunks +16 lines, -35 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/configuration_policy_provider_test.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M components/policy/core/common/generate_policy_source_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/policy/core/common/policy_bundle_unittest.cc View 6 chunks +32 lines, -68 lines 0 comments Download
M components/policy/core/common/policy_loader_mac.mm View 1 2 5 chunks +6 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_loader_mac_unittest.cc View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -7 lines 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +22 lines, -34 lines 0 comments Download
M components/policy/core/common/policy_map.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M components/policy/core/common/policy_map.cc View 1 7 chunks +47 lines, -66 lines 0 comments Download
M components/policy/core/common/policy_map_unittest.cc View 8 chunks +116 lines, -205 lines 0 comments Download
M components/policy/core/common/policy_service_impl.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -8 lines 0 comments Download
M components/policy/core/common/policy_service_impl_unittest.cc View 22 chunks +96 lines, -185 lines 0 comments Download
M components/policy/core/common/policy_statistics_collector_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M components/policy/core/common/proxy_policy_provider_unittest.cc View 1 2 3 4 3 chunks +5 lines, -10 lines 0 comments Download
M components/policy/core/common/schema_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema_map_unittest.cc View 5 chunks +59 lines, -106 lines 0 comments Download
M components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc View 5 chunks +13 lines, -27 lines 0 comments Download
M components/policy/tools/generate_policy_source.py View 8 chunks +21 lines, -17 lines 0 comments Download
M components/search_engines/default_search_policy_handler_unittest.cc View 5 chunks +48 lines, -91 lines 0 comments Download
M components/sync_driver/sync_policy_handler_unittest.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M remoting/host/policy_watcher.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
dcheng
+atwilson for //chrome/browser/chromeos/policy and //components/policy +jochen for //chrome and //components files outside the previous two ...
4 years, 7 months ago (2016-05-03 06:46:18 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-03 10:59:44 UTC) #4
Andrew T Wilson (Slow)
*/policy/* LGTM with nits and want to make sure that TODO() is addressed to your ...
4 years, 7 months ago (2016-05-03 11:59:04 UTC) #5
joedow
lgtm for remoting
4 years, 7 months ago (2016-05-03 15:35:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940153002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940153002/140001
4 years, 7 months ago (2016-05-03 23:30:50 UTC) #9
dcheng
atwilson: PTAL https://codereview.chromium.org/1940153002/diff/80001/components/policy/core/browser/proxy_policy_handler_unittest.cc File components/policy/core/browser/proxy_policy_handler_unittest.cc (right): https://codereview.chromium.org/1940153002/diff/80001/components/policy/core/browser/proxy_policy_handler_unittest.cc#newcode287 components/policy/core/browser/proxy_policy_handler_unittest.cc:287: key::kProxyPacUrl, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, On 2016/05/03 at 11:59:03, ...
4 years, 7 months ago (2016-05-03 23:40:40 UTC) #11
dcheng
atwilson: ping
4 years, 7 months ago (2016-05-09 20:02:41 UTC) #12
Andrew T Wilson (Slow)
On 2016/05/09 20:02:41, dcheng wrote: > atwilson: ping still lgtm :)
4 years, 7 months ago (2016-05-09 22:08:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940153002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940153002/200001
4 years, 7 months ago (2016-05-10 01:37:28 UTC) #16
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 7 months ago (2016-05-10 02:26:27 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:27:36 UTC) #19
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/3b344bc2793161243e2718cc02a311143440396f
Cr-Commit-Position: refs/heads/master@{#392521}

Powered by Google App Engine
This is Rietveld 408576698