Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
index a94469fc6313848b66ce69fd968ed4eef82b65f1..a6a5732306c35af1ac16bbdf1360f9b72cd5d3f9 100644
--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
@@ -157,12 +157,10 @@ void CloudExternalDataManagerBaseTest::SetUp() {
SetUpExternalDataManager();
// Set |kStringPolicy| to a string value.
- cloud_policy_store_.policy_map_.Set(kStringPolicy,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- new base::StringValue(std::string()),
- NULL);
+ cloud_policy_store_.policy_map_.Set(
+ kStringPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::StringValue(std::string())), nullptr);
// Make |k10BytePolicy| reference 10 bytes of external data.
SetExternalDataReference(
k10BytePolicy,
@@ -213,13 +211,10 @@ void CloudExternalDataManagerBaseTest::SetExternalDataReference(
const std::string& policy,
std::unique_ptr<base::DictionaryValue> metadata) {
cloud_policy_store_.policy_map_.Set(
- policy,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- metadata.release(),
- new ExternalDataFetcher(
- external_data_manager_->weak_factory_.GetWeakPtr(), policy));
+ policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+ std::move(metadata),
+ base::WrapUnique(new ExternalDataFetcher(
+ external_data_manager_->weak_factory_.GetWeakPtr(), policy)));
}
ExternalDataFetcher::FetchCallback

Powered by Google App Engine
This is Rietveld 408576698