chrome/browser/extensions/api/storage/policy_value_store_unittest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc ('k') | chrome/browser/extensions/extension_management_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

index de089d4523355f0e5a9572855f79c40ae69c3edb..53b1f76a6bbcc7b440e4841d94349203ec7d7011 100644

--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

@@ -125,10 +125,10 @@ TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {

base::FundamentalValue expected(123);

policies.Set("must", policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

- expected.DeepCopy(), nullptr);

+ expected.CreateDeepCopy(), nullptr);

policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

- new base::FundamentalValue(456), NULL);

+ base::WrapUnique(new base::FundamentalValue(456)), nullptr);

store_->SetCurrentPolicy(policies);

ValueStore::ReadResult result = store_->Get();

ASSERT_TRUE(result->status().ok());

@@ -170,7 +170,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {

policy::PolicyMap policies;

policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);

+ policy::POLICY_SOURCE_CLOUD, value.CreateDeepCopy(), nullptr);

store_->SetCurrentPolicy(policies);

loop_.RunUntilIdle();

Mock::VerifyAndClearExpectations(&observer_);

@@ -186,7 +186,7 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {

}

policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);

+ policy::POLICY_SOURCE_CLOUD, value.CreateDeepCopy(), nullptr);

store_->SetCurrentPolicy(policies);

loop_.RunUntilIdle();

Mock::VerifyAndClearExpectations(&observer_);

@@ -204,7 +204,8 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {

}

policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD, new_value.DeepCopy(), nullptr);

+ policy::POLICY_SOURCE_CLOUD, new_value.CreateDeepCopy(),

+ nullptr);

store_->SetCurrentPolicy(policies);

loop_.RunUntilIdle();

Mock::VerifyAndClearExpectations(&observer_);