chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc ('k') | chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

diff --git a/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc b/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

index 854fa226edb3e7b0d8cd9a61b5114e769acff909..256a68382416377d40d4230e36653165cbf4cb93 100644

--- a/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

+++ b/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc

@@ -352,14 +352,11 @@ void CloudExternalDataPolicyObserverTest::SetRegularUserAvatarPolicy(

const std::string& value) {

PolicyMap policy_map;

if (!value.empty()) {

- policy_map.Set(

- key::kUserAvatarImage,

- POLICY_LEVEL_MANDATORY,

- POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- new base::StringValue(value),

- external_data_manager_.CreateExternalDataFetcher(

- key::kUserAvatarImage).release());

+ policy_map.Set(key::kUserAvatarImage, POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

+ base::WrapUnique(new base::StringValue(value)),

+ external_data_manager_.CreateExternalDataFetcher(

+ key::kUserAvatarImage));

}

user_policy_provider_.UpdateChromePolicy(policy_map);

}