components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc ('k') | components/policy/core/common/configuration_policy_provider_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc

diff --git a/components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc b/components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc

index 625f6ef4efc8406a6b53644e218129631f06f027..8c41cca0af6c0a2ce9a46f5bde2fa04e97d0859d 100644

--- a/components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc

+++ b/components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc

@@ -101,7 +101,7 @@ class UserCloudPolicyStoreTest : public testing::Test {

const PolicyMap::Entry* entry =

store->policy_map().Get(key::kPasswordManagerEnabled);

ASSERT_TRUE(entry);

- EXPECT_TRUE(base::FundamentalValue(true).Equals(entry->value));

+ EXPECT_TRUE(base::FundamentalValue(true).Equals(entry->value.get()));

ASSERT_TRUE(store->policy_map().Get(key::kURLBlacklist));

}