Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: chrome/browser/policy/policy_network_browsertest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h"
8 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
9 #include "base/run_loop.h" 10 #include "base/run_loop.h"
10 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
11 #include "chrome/common/chrome_switches.h" 12 #include "chrome/common/chrome_switches.h"
12 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
13 #include "components/policy/core/browser/browser_policy_connector.h" 14 #include "components/policy/core/browser/browser_policy_connector.h"
14 #include "components/policy/core/common/mock_configuration_policy_provider.h" 15 #include "components/policy/core/common/mock_configuration_policy_provider.h"
15 #include "components/policy/core/common/policy_map.h" 16 #include "components/policy/core/common/policy_map.h"
16 #include "components/policy/core/common/policy_types.h" 17 #include "components/policy/core/common/policy_types.h"
17 #include "content/public/browser/browser_thread.h" 18 #include "content/public/browser/browser_thread.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 }; 77 };
77 78
78 // Policy QuicAllowed set to false. 79 // Policy QuicAllowed set to false.
79 class QuicAllowedPolicyIsFalse: public QuicAllowedPolicyTestBase { 80 class QuicAllowedPolicyIsFalse: public QuicAllowedPolicyTestBase {
80 public: 81 public:
81 QuicAllowedPolicyIsFalse() : QuicAllowedPolicyTestBase(){} 82 QuicAllowedPolicyIsFalse() : QuicAllowedPolicyTestBase(){}
82 83
83 protected: 84 protected:
84 void GetQuicAllowedPolicy(PolicyMap* values) override { 85 void GetQuicAllowedPolicy(PolicyMap* values) override {
85 values->Set(key::kQuicAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, 86 values->Set(key::kQuicAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
86 POLICY_SOURCE_CLOUD, new base::FundamentalValue(false), nullptr); 87 POLICY_SOURCE_CLOUD,
88 base::WrapUnique(new base::FundamentalValue(false)), nullptr);
87 } 89 }
88 90
89 private: 91 private:
90 DISALLOW_COPY_AND_ASSIGN(QuicAllowedPolicyIsFalse); 92 DISALLOW_COPY_AND_ASSIGN(QuicAllowedPolicyIsFalse);
91 }; 93 };
92 94
93 IN_PROC_BROWSER_TEST_F(QuicAllowedPolicyIsFalse, QuicDisallowed) { 95 IN_PROC_BROWSER_TEST_F(QuicAllowedPolicyIsFalse, QuicDisallowed) {
94 VerifyQuicEnabledStatusInIOThread(false); 96 VerifyQuicEnabledStatusInIOThread(false);
95 } 97 }
96 98
97 // Policy QuicAllowed set to true. 99 // Policy QuicAllowed set to true.
98 class QuicAllowedPolicyIsTrue: public QuicAllowedPolicyTestBase { 100 class QuicAllowedPolicyIsTrue: public QuicAllowedPolicyTestBase {
99 public: 101 public:
100 QuicAllowedPolicyIsTrue() : QuicAllowedPolicyTestBase(){} 102 QuicAllowedPolicyIsTrue() : QuicAllowedPolicyTestBase(){}
101 103
102 protected: 104 protected:
103 void GetQuicAllowedPolicy(PolicyMap* values) override { 105 void GetQuicAllowedPolicy(PolicyMap* values) override {
104 values->Set(key::kQuicAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, 106 values->Set(key::kQuicAllowed, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
105 POLICY_SOURCE_CLOUD, new base::FundamentalValue(true), nullptr); 107 POLICY_SOURCE_CLOUD,
108 base::WrapUnique(new base::FundamentalValue(true)), nullptr);
106 } 109 }
107 110
108 private: 111 private:
109 DISALLOW_COPY_AND_ASSIGN(QuicAllowedPolicyIsTrue); 112 DISALLOW_COPY_AND_ASSIGN(QuicAllowedPolicyIsTrue);
110 }; 113 };
111 114
112 IN_PROC_BROWSER_TEST_F(QuicAllowedPolicyIsTrue, QuicAllowed) { 115 IN_PROC_BROWSER_TEST_F(QuicAllowedPolicyIsTrue, QuicAllowed) {
113 VerifyQuicEnabledStatusInIOThread(true); 116 VerifyQuicEnabledStatusInIOThread(true);
114 } 117 }
115 118
116 // Policy QuicAllowed is not set. 119 // Policy QuicAllowed is not set.
117 class QuicAllowedPolicyIsNotSet: public QuicAllowedPolicyTestBase { 120 class QuicAllowedPolicyIsNotSet: public QuicAllowedPolicyTestBase {
118 public: 121 public:
119 QuicAllowedPolicyIsNotSet() : QuicAllowedPolicyTestBase(){} 122 QuicAllowedPolicyIsNotSet() : QuicAllowedPolicyTestBase(){}
120 123
121 protected: 124 protected:
122 void GetQuicAllowedPolicy(PolicyMap* values) override { 125 void GetQuicAllowedPolicy(PolicyMap* values) override {
123 } 126 }
124 127
125 private: 128 private:
126 DISALLOW_COPY_AND_ASSIGN(QuicAllowedPolicyIsNotSet); 129 DISALLOW_COPY_AND_ASSIGN(QuicAllowedPolicyIsNotSet);
127 }; 130 };
128 131
129 IN_PROC_BROWSER_TEST_F(QuicAllowedPolicyIsNotSet, NoQuicRegulations) { 132 IN_PROC_BROWSER_TEST_F(QuicAllowedPolicyIsNotSet, NoQuicRegulations) {
130 VerifyQuicEnabledStatusInIOThread(true); 133 VerifyQuicEnabledStatusInIOThread(true);
131 } 134 }
132 135
133 } // namespace policy 136 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/policy/policy_prefs_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698