Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/search/contextual_search_policy_handler_android_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ptr_util.h"
5 #include "base/values.h" 6 #include "base/values.h"
6 #include "chrome/browser/search/contextual_search_policy_handler_android.h" 7 #include "chrome/browser/search/contextual_search_policy_handler_android.h"
7 #include "chrome/common/pref_names.h" 8 #include "chrome/common/pref_names.h"
8 #include "components/policy/core/common/policy_map.h" 9 #include "components/policy/core/common/policy_map.h"
9 #include "components/prefs/pref_value_map.h" 10 #include "components/prefs/pref_value_map.h"
10 #include "policy/policy_constants.h" 11 #include "policy/policy_constants.h"
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 13
13 namespace policy { 14 namespace policy {
14 15
15 TEST(ContextualSearchPolicyHandlerAndroidTest, Default) { 16 TEST(ContextualSearchPolicyHandlerAndroidTest, Default) {
16 PolicyMap policy; 17 PolicyMap policy;
17 PrefValueMap prefs; 18 PrefValueMap prefs;
18 ContextualSearchPolicyHandlerAndroid handler; 19 ContextualSearchPolicyHandlerAndroid handler;
19 handler.ApplyPolicySettings(policy, &prefs); 20 handler.ApplyPolicySettings(policy, &prefs);
20 std::string pref_value; 21 std::string pref_value;
21 EXPECT_FALSE(prefs.GetString(prefs::kContextualSearchEnabled, &pref_value)); 22 EXPECT_FALSE(prefs.GetString(prefs::kContextualSearchEnabled, &pref_value));
22 EXPECT_EQ("", pref_value); 23 EXPECT_EQ("", pref_value);
23 } 24 }
24 25
25 TEST(ContextualSearchPolicyHandlerAndroidTest, Enabled) { 26 TEST(ContextualSearchPolicyHandlerAndroidTest, Enabled) {
26 PolicyMap policy; 27 PolicyMap policy;
27 policy.Set(key::kContextualSearchEnabled, 28 policy.Set(key::kContextualSearchEnabled, POLICY_LEVEL_MANDATORY,
28 POLICY_LEVEL_MANDATORY, 29 POLICY_SCOPE_USER, POLICY_SOURCE_PLATFORM,
29 POLICY_SCOPE_USER, 30 base::WrapUnique(new base::FundamentalValue(true)), nullptr);
30 POLICY_SOURCE_PLATFORM,
31 new base::FundamentalValue(true),
32 NULL);
33 PrefValueMap prefs; 31 PrefValueMap prefs;
34 ContextualSearchPolicyHandlerAndroid handler; 32 ContextualSearchPolicyHandlerAndroid handler;
35 handler.ApplyPolicySettings(policy, &prefs); 33 handler.ApplyPolicySettings(policy, &prefs);
36 34
37 // Enabling Contextual Search policy should not set the pref. 35 // Enabling Contextual Search policy should not set the pref.
38 std::string pref_value; 36 std::string pref_value;
39 EXPECT_FALSE(prefs.GetString(prefs::kContextualSearchEnabled, &pref_value)); 37 EXPECT_FALSE(prefs.GetString(prefs::kContextualSearchEnabled, &pref_value));
40 EXPECT_EQ("", pref_value); 38 EXPECT_EQ("", pref_value);
41 } 39 }
42 40
43 TEST(ContextualSearchPolicyHandlerAndroidTest, Disabled) { 41 TEST(ContextualSearchPolicyHandlerAndroidTest, Disabled) {
44 PolicyMap policy; 42 PolicyMap policy;
45 policy.Set(key::kContextualSearchEnabled, 43 policy.Set(key::kContextualSearchEnabled, POLICY_LEVEL_MANDATORY,
46 POLICY_LEVEL_MANDATORY, 44 POLICY_SCOPE_USER, POLICY_SOURCE_PLATFORM,
47 POLICY_SCOPE_USER, 45 base::WrapUnique(new base::FundamentalValue(false)), nullptr);
48 POLICY_SOURCE_PLATFORM,
49 new base::FundamentalValue(false),
50 NULL);
51 PrefValueMap prefs; 46 PrefValueMap prefs;
52 ContextualSearchPolicyHandlerAndroid handler; 47 ContextualSearchPolicyHandlerAndroid handler;
53 handler.ApplyPolicySettings(policy, &prefs); 48 handler.ApplyPolicySettings(policy, &prefs);
54 49
55 // Disabling Contextual Search should switch the pref to managed. 50 // Disabling Contextual Search should switch the pref to managed.
56 std::string pref_value; 51 std::string pref_value;
57 EXPECT_TRUE(prefs.GetString(prefs::kContextualSearchEnabled, &pref_value)); 52 EXPECT_TRUE(prefs.GetString(prefs::kContextualSearchEnabled, &pref_value));
58 EXPECT_EQ("false", pref_value); 53 EXPECT_EQ("false", pref_value);
59 } 54 }
60 55
61 } // namespace policy 56 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698