chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/saml/saml_browsertest.cc ('k') | chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc

diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc

index e9020f648185e402f10a4342bfa2ae56d50c4999..27f2269d8a06056f661297880fdc0db4f214bcbd 100644

--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc

+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc

@@ -7,6 +7,7 @@

#include <utility>

#include "base/callback.h"

+#include "base/memory/ptr_util.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string_number_conversions.h"

#include "base/values.h"

@@ -46,11 +47,10 @@ void SetExternalDataReference(CloudPolicyCore* core,

CloudPolicyStore* store = core->store();

ASSERT_TRUE(store);

PolicyMap policy_map;

- policy_map.Set(policy,

- POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- metadata.release(),

- new ExternalDataFetcher(store->external_data_manager(),

- policy));

+ policy_map.Set(policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

+ POLICY_SOURCE_CLOUD, std::move(metadata),

+ base::WrapUnique(new ExternalDataFetcher(

+ store->external_data_manager(), policy)));

store->SetPolicyMapForTesting(policy_map);

}