Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_browsertest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
diff --git a/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc b/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
index d68ae7f78c722d11b32914287211f2e07e31e00a..106d9af915bee3f67985f1c5f338eef6cacead4e 100644
--- a/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
+++ b/chrome/browser/ui/webui/options/certificate_manager_browsertest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -48,12 +49,10 @@ class CertificateManagerBrowserTest : public options::OptionsUIBrowserTest {
const std::string& user_policy_blob =
chromeos::onc::test_utils::ReadTestData(filename);
policy::PolicyMap policy;
- policy.Set(policy::key::kOpenNetworkConfiguration,
- policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER,
- policy::POLICY_SOURCE_CLOUD,
- new base::StringValue(user_policy_blob),
- NULL);
+ policy.Set(
+ policy::key::kOpenNetworkConfiguration, policy::POLICY_LEVEL_MANDATORY,
+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::StringValue(user_policy_blob)), nullptr);
provider_.UpdateChromePolicy(policy);
content::RunAllPendingInMessageLoop();
}

Powered by Google App Engine
This is Rietveld 408576698