Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 " \"Passphrase\": \"passphrase\"," 588 " \"Passphrase\": \"passphrase\","
589 " \"Recommended\": [ \"AutoConnect\", \"Passphrase\" ]," 589 " \"Recommended\": [ \"AutoConnect\", \"Passphrase\" ],"
590 " \"Security\": \"WPA-PSK\" }" 590 " \"Security\": \"WPA-PSK\" }"
591 " }" 591 " }"
592 " ]," 592 " ],"
593 " \"Certificates\": []," 593 " \"Certificates\": [],"
594 " \"Type\": \"UnencryptedConfiguration\"" 594 " \"Type\": \"UnencryptedConfiguration\""
595 "}"; 595 "}";
596 596
597 policy::PolicyMap policy; 597 policy::PolicyMap policy;
598 policy.Set(policy::key::kOpenNetworkConfiguration, 598 policy.Set(
599 policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER, 599 policy::key::kOpenNetworkConfiguration, policy::POLICY_LEVEL_MANDATORY,
600 policy::POLICY_SOURCE_CLOUD, 600 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
601 new base::StringValue(user_policy_blob), nullptr); 601 base::WrapUnique(new base::StringValue(user_policy_blob)), nullptr);
602 provider_.UpdateChromePolicy(policy); 602 provider_.UpdateChromePolicy(policy);
603 603
604 content::RunAllPendingInMessageLoop(); 604 content::RunAllPendingInMessageLoop();
605 605
606 EXPECT_TRUE(RunNetworkingSubtest("getManagedProperties")) << message_; 606 EXPECT_TRUE(RunNetworkingSubtest("getManagedProperties")) << message_;
607 } 607 }
608 608
609 IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, GetErrorState) { 609 IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, GetErrorState) {
610 chromeos::NetworkHandler::Get()->network_state_handler()->SetLastErrorForTest( 610 chromeos::NetworkHandler::Get()->network_state_handler()->SetLastErrorForTest(
611 kWifi1ServicePath, "TestErrorState"); 611 kWifi1ServicePath, "TestErrorState");
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 } 707 }
708 708
709 IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, CellularSimPuk) { 709 IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, CellularSimPuk) {
710 SetupCellular(); 710 SetupCellular();
711 // Lock the SIM 711 // Lock the SIM
712 device_test_->SetSimLocked(kCellularDevicePath, true); 712 device_test_->SetSimLocked(kCellularDevicePath, true);
713 EXPECT_TRUE(RunNetworkingSubtest("cellularSimPuk")) << message_; 713 EXPECT_TRUE(RunNetworkingSubtest("cellularSimPuk")) << message_;
714 } 714 }
715 715
716 } // namespace 716 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698