chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc ('k') | chrome/browser/chromeos/policy/device_local_account_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

index 33732c85dc53b8a20cbab9b627ca114a69b6f6a5..ba4af7ba9b71e04ef80b66c6e57a56601aa507e0 100644

--- a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

@@ -187,12 +187,9 @@ class DeviceCloudPolicyManagerChromeOSTest

void VerifyPolicyPopulated() {

PolicyBundle bundle;

bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))

- .Set(key::kDeviceMetricsReportingEnabled,

- POLICY_LEVEL_MANDATORY,

- POLICY_SCOPE_MACHINE,

- POLICY_SOURCE_CLOUD,

- new base::FundamentalValue(false),

- NULL);

+ .Set(key::kDeviceMetricsReportingEnabled, POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_MACHINE, POLICY_SOURCE_CLOUD,

+ base::WrapUnique(new base::FundamentalValue(false)), nullptr);

EXPECT_TRUE(manager_->policies().Equals(bundle));

}