components/policy/core/browser/android/policy_converter.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/android/policy_converter.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/policy_ui_handler.cc ('k') | components/policy/core/browser/autofill_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/android/policy_converter.cc

diff --git a/components/policy/core/browser/android/policy_converter.cc b/components/policy/core/browser/android/policy_converter.cc

index 8a431829b1af38fe8f919bb2e604a2aa27ef93ea..5a410947861707cce15370d56a4d503e4cbf8d81 100644

--- a/components/policy/core/browser/android/policy_converter.cc

+++ b/components/policy/core/browser/android/policy_converter.cc

@@ -195,7 +195,7 @@ void PolicyConverter::SetPolicyValue(const std::string& key,

const PolicyNamespace ns(POLICY_DOMAIN_CHROME, std::string());

policy_bundle_->Get(ns).Set(

key, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE, POLICY_SOURCE_PLATFORM,

- ConvertValueToSchema(std::move(value), schema).release(), nullptr);

+ ConvertValueToSchema(std::move(value), schema), nullptr);

}

} // namespace android

« no previous file with comments | « chrome/browser/ui/webui/policy_ui_handler.cc ('k') | components/policy/core/browser/autofill_policy_handler_unittest.cc » ('j') | no next file with comments »