Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
diff --git a/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc b/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
index 3eaa46e0759391b763e30e462ecaebea5c869f98..3709a6518d0d4efd6728f7a7e32ed33ee8479698 100644
--- a/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
+++ b/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/browser/policy/file_selection_dialogs_policy_handler.h"
#include "chrome/common/pref_names.h"
@@ -28,12 +29,9 @@ TEST_F(FileSelectionDialogsPolicyTest, Default) {
}
TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {
- policy_.Set(key::kAllowFileSelectionDialogs,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- new base::FundamentalValue(true),
- NULL);
+ policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,
+ POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::FundamentalValue(true)), nullptr);
handler_.ApplyPolicySettings(policy_, &prefs_);
// Allowing file-selection dialogs should not influence the PromptForDownload
@@ -42,12 +40,9 @@ TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {
}
TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) {
- policy_.Set(key::kAllowFileSelectionDialogs,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- new base::FundamentalValue(false),
- NULL);
+ policy_.Set(key::kAllowFileSelectionDialogs, POLICY_LEVEL_MANDATORY,
+ POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::FundamentalValue(false)), nullptr);
handler_.ApplyPolicySettings(policy_, &prefs_);
// Disabling file-selection dialogs should disable the PromptForDownload pref.
« no previous file with comments | « chrome/browser/policy/cloud/cloud_policy_browsertest.cc ('k') | chrome/browser/policy/javascript_policy_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698