Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h" 5 #include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 CloudExternalDataManagerBaseTest::CloudExternalDataManagerBaseTest() { 150 CloudExternalDataManagerBaseTest::CloudExternalDataManagerBaseTest() {
151 } 151 }
152 152
153 void CloudExternalDataManagerBaseTest::SetUp() { 153 void CloudExternalDataManagerBaseTest::SetUp() {
154 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 154 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
155 resource_cache_.reset( 155 resource_cache_.reset(
156 new ResourceCache(temp_dir_.path(), message_loop_.task_runner())); 156 new ResourceCache(temp_dir_.path(), message_loop_.task_runner()));
157 SetUpExternalDataManager(); 157 SetUpExternalDataManager();
158 158
159 // Set |kStringPolicy| to a string value. 159 // Set |kStringPolicy| to a string value.
160 cloud_policy_store_.policy_map_.Set(kStringPolicy, 160 cloud_policy_store_.policy_map_.Set(
161 POLICY_LEVEL_MANDATORY, 161 kStringPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
162 POLICY_SCOPE_USER, 162 POLICY_SOURCE_CLOUD,
163 POLICY_SOURCE_CLOUD, 163 base::WrapUnique(new base::StringValue(std::string())), nullptr);
164 new base::StringValue(std::string()),
165 NULL);
166 // Make |k10BytePolicy| reference 10 bytes of external data. 164 // Make |k10BytePolicy| reference 10 bytes of external data.
167 SetExternalDataReference( 165 SetExternalDataReference(
168 k10BytePolicy, 166 k10BytePolicy,
169 ConstructMetadata(k10BytePolicyURL, 167 ConstructMetadata(k10BytePolicyURL,
170 crypto::SHA256HashString(k10ByteData))); 168 crypto::SHA256HashString(k10ByteData)));
171 // Make |k20BytePolicy| reference 20 bytes of external data. 169 // Make |k20BytePolicy| reference 20 bytes of external data.
172 SetExternalDataReference( 170 SetExternalDataReference(
173 k20BytePolicy, 171 k20BytePolicy,
174 ConstructMetadata(k20BytePolicyURL, 172 ConstructMetadata(k20BytePolicyURL,
175 crypto::SHA256HashString(k20ByteData))); 173 crypto::SHA256HashString(k20ByteData)));
(...skipping 30 matching lines...) Expand all
206 metadata->SetStringWithoutPathExpansion("url", url); 204 metadata->SetStringWithoutPathExpansion("url", url);
207 metadata->SetStringWithoutPathExpansion("hash", base::HexEncode(hash.c_str(), 205 metadata->SetStringWithoutPathExpansion("hash", base::HexEncode(hash.c_str(),
208 hash.size())); 206 hash.size()));
209 return metadata; 207 return metadata;
210 } 208 }
211 209
212 void CloudExternalDataManagerBaseTest::SetExternalDataReference( 210 void CloudExternalDataManagerBaseTest::SetExternalDataReference(
213 const std::string& policy, 211 const std::string& policy,
214 std::unique_ptr<base::DictionaryValue> metadata) { 212 std::unique_ptr<base::DictionaryValue> metadata) {
215 cloud_policy_store_.policy_map_.Set( 213 cloud_policy_store_.policy_map_.Set(
216 policy, 214 policy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
217 POLICY_LEVEL_MANDATORY, 215 std::move(metadata),
218 POLICY_SCOPE_USER, 216 base::WrapUnique(new ExternalDataFetcher(
219 POLICY_SOURCE_CLOUD, 217 external_data_manager_->weak_factory_.GetWeakPtr(), policy)));
220 metadata.release(),
221 new ExternalDataFetcher(
222 external_data_manager_->weak_factory_.GetWeakPtr(), policy));
223 } 218 }
224 219
225 ExternalDataFetcher::FetchCallback 220 ExternalDataFetcher::FetchCallback
226 CloudExternalDataManagerBaseTest::ConstructFetchCallback(int id) { 221 CloudExternalDataManagerBaseTest::ConstructFetchCallback(int id) {
227 return base::Bind(&CloudExternalDataManagerBaseTest::OnFetchDone, 222 return base::Bind(&CloudExternalDataManagerBaseTest::OnFetchDone,
228 base::Unretained(this), 223 base::Unretained(this),
229 id); 224 id);
230 } 225 }
231 226
232 void CloudExternalDataManagerBaseTest::ResetCallbackData() { 227 void CloudExternalDataManagerBaseTest::ResetCallbackData() {
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 crypto::SHA256HashString(k10ByteData))); 759 crypto::SHA256HashString(k10ByteData)));
765 cloud_policy_store_.NotifyStoreLoaded(); 760 cloud_policy_store_.NotifyStoreLoaded();
766 base::RunLoop().RunUntilIdle(); 761 base::RunLoop().RunUntilIdle();
767 EXPECT_EQ(1u, callback_data_.size()); 762 EXPECT_EQ(1u, callback_data_.size());
768 ASSERT_TRUE(callback_data_[1]); 763 ASSERT_TRUE(callback_data_[1]);
769 EXPECT_EQ(k10ByteData, *callback_data_[1]); 764 EXPECT_EQ(k10ByteData, *callback_data_[1]);
770 ResetCallbackData(); 765 ResetCallbackData();
771 } 766 }
772 767
773 } // namespace policy 768 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698