Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

components/policy/core/browser/configuration_policy_pref_store_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/browser/configuration_policy_pref_store.h"
 
+#include <memory>
 #include <string>
+#include <utility>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "components/policy/core/browser/configuration_policy_handler.h"
 #include "components/policy/core/browser/configuration_policy_pref_store_test.h"
 #include "components/policy/core/common/external_data_fetcher.h"
 #include "components/policy/core/common/policy_details.h"
 #include "components/policy/core/common/policy_map.h"
@@ skipping 29 matching lines @@
         base::WrapUnique<ConfigurationPolicyHandler>(new SimplePolicyHandler(
             kTestPolicy, kTestPref, base::Value::TYPE_LIST)));
   }
 };
 
 TEST_F(ConfigurationPolicyPrefStoreListTest, GetDefault) {
   EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreListTest, SetValue) {
-  base::ListValue* in_value = new base::ListValue();
+  std::unique_ptr<base::ListValue> in_value(new base::ListValue());
   in_value->Append(new base::StringValue("test1"));
   in_value->Append(new base::StringValue("test2,"));
   PolicyMap policy;
   policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-             POLICY_SOURCE_CLOUD, in_value, nullptr);
+             POLICY_SOURCE_CLOUD, in_value->CreateDeepCopy(), nullptr);
   UpdateProviderPolicy(policy);
   const base::Value* value = NULL;
   EXPECT_TRUE(store_->GetValue(kTestPref, &value));
   ASSERT_TRUE(value);
   EXPECT_TRUE(in_value->Equals(value));
 }
 
 // Test cases for string-valued policy settings.
 class ConfigurationPolicyPrefStoreStringTest
     : public ConfigurationPolicyPrefStoreTest {
   void SetUp() override {
     handler_list_.AddHandler(
         base::WrapUnique<ConfigurationPolicyHandler>(new SimplePolicyHandler(
             kTestPolicy, kTestPref, base::Value::TYPE_STRING)));
   }
 };
 
 TEST_F(ConfigurationPolicyPrefStoreStringTest, GetDefault) {
   EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreStringTest, SetValue) {
   PolicyMap policy;
-  policy.Set(kTestPolicy,
-             POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
+  policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              POLICY_SOURCE_CLOUD,
-             new base::StringValue("http://chromium.org"),
-             NULL);
+             base::WrapUnique(new base::StringValue("http://chromium.org")),
+             nullptr);
   UpdateProviderPolicy(policy);
   const base::Value* value = NULL;
   EXPECT_TRUE(store_->GetValue(kTestPref, &value));
   ASSERT_TRUE(value);
   EXPECT_TRUE(base::StringValue("http://chromium.org").Equals(value));
 }
 
 // Test cases for boolean-valued policy settings.
 class ConfigurationPolicyPrefStoreBooleanTest
     : public ConfigurationPolicyPrefStoreTest {
   void SetUp() override {
     handler_list_.AddHandler(
         base::WrapUnique<ConfigurationPolicyHandler>(new SimplePolicyHandler(
             kTestPolicy, kTestPref, base::Value::TYPE_BOOLEAN)));
   }
 };
 
 TEST_F(ConfigurationPolicyPrefStoreBooleanTest, GetDefault) {
   EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
   PolicyMap policy;
-  policy.Set(kTestPolicy,
-             POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
+  policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              POLICY_SOURCE_CLOUD,
-             new base::FundamentalValue(false),
-             NULL);
+             base::WrapUnique(new base::FundamentalValue(false)), nullptr);
   UpdateProviderPolicy(policy);
   const base::Value* value = NULL;
   EXPECT_TRUE(store_->GetValue(kTestPref, &value));
   ASSERT_TRUE(value);
   bool boolean_value = true;
   bool result = value->GetAsBoolean(&boolean_value);
   ASSERT_TRUE(result);
   EXPECT_FALSE(boolean_value);
 
-  policy.Set(kTestPolicy,
-             POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
+  policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              POLICY_SOURCE_CLOUD,
-             new base::FundamentalValue(true),
-             NULL);
+             base::WrapUnique(new base::FundamentalValue(true)), nullptr);
   UpdateProviderPolicy(policy);
   value = NULL;
   EXPECT_TRUE(store_->GetValue(kTestPref, &value));
   boolean_value = false;
   result = value->GetAsBoolean(&boolean_value);
   ASSERT_TRUE(result);
   EXPECT_TRUE(boolean_value);
 }
 
 // Test cases for integer-valued policy settings.
 class ConfigurationPolicyPrefStoreIntegerTest
     : public ConfigurationPolicyPrefStoreTest {
   void SetUp() override {
     handler_list_.AddHandler(
         base::WrapUnique<ConfigurationPolicyHandler>(new SimplePolicyHandler(
             kTestPolicy, kTestPref, base::Value::TYPE_INTEGER)));
   }
 };
 
 TEST_F(ConfigurationPolicyPrefStoreIntegerTest, GetDefault) {
   EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreIntegerTest, SetValue) {
   PolicyMap policy;
-  policy.Set(kTestPolicy,
-             POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
+  policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              POLICY_SOURCE_CLOUD,
-             new base::FundamentalValue(2),
-             NULL);
+             base::WrapUnique(new base::FundamentalValue(2)), nullptr);
   UpdateProviderPolicy(policy);
   const base::Value* value = NULL;
   EXPECT_TRUE(store_->GetValue(kTestPref, &value));
   EXPECT_TRUE(base::FundamentalValue(2).Equals(value));
 }
 
 // Exercises the policy refresh mechanism.
 class ConfigurationPolicyPrefStoreRefreshTest
     : public ConfigurationPolicyPrefStoreTest {
  protected:
@@ skipping 11 matching lines @@
   }
 
   PrefStoreObserverMock observer_;
 };
 
 TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {
   const base::Value* value = NULL;
   EXPECT_FALSE(store_->GetValue(kTestPolicy, NULL));
 
   PolicyMap policy;
-  policy.Set(kTestPolicy,
-             POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
+  policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              POLICY_SOURCE_CLOUD,
-             new base::StringValue("http://www.chromium.org"),
-             NULL);
+             base::WrapUnique(new base::StringValue("http://www.chromium.org")),
+             nullptr);
   UpdateProviderPolicy(policy);
   observer_.VerifyAndResetChangedKey(kTestPref);
   EXPECT_TRUE(store_->GetValue(kTestPref, &value));
   EXPECT_TRUE(base::StringValue("http://www.chromium.org").Equals(value));
 
   UpdateProviderPolicy(policy);
   EXPECT_TRUE(observer_.changed_keys.empty());
 
   policy.Erase(kTestPolicy);
   UpdateProviderPolicy(policy);
   observer_.VerifyAndResetChangedKey(kTestPref);
   EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
 }
 
 TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Initialization) {
   EXPECT_FALSE(store_->IsInitializationComplete());
   EXPECT_CALL(provider_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
       .WillRepeatedly(Return(true));
   PolicyMap policy;
   UpdateProviderPolicy(policy);
   EXPECT_TRUE(observer_.initialized);
   EXPECT_TRUE(observer_.initialization_success);
   Mock::VerifyAndClearExpectations(&observer_);
   EXPECT_TRUE(store_->IsInitializationComplete());
 }
 
 }  // namespace policy