Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

chrome/browser/policy/cloud/cloud_policy_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 132 matching lines @@
 
   return base::StringPrintf(kTestPolicy,
                             dm_protocol::kChromeUserPolicyType,
                             homepage,
                             GetTestUser(),
                             key_version);
 }
 
 void GetExpectedDefaultPolicy(PolicyMap* policy_map) {
 #if defined(OS_CHROMEOS)
-  policy_map->Set(key::kChromeOsMultiProfileUserBehavior,
-                  POLICY_LEVEL_MANDATORY,
-                  POLICY_SCOPE_USER,
+  policy_map->Set(
+      key::kChromeOsMultiProfileUserBehavior, POLICY_LEVEL_MANDATORY,
+      POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
+      base::WrapUnique(new base::StringValue("primary-only")), nullptr);
+  policy_map->Set(key::kEasyUnlockAllowed, POLICY_LEVEL_MANDATORY,
+                  POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
+                  base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+  policy_map->Set(key::kCaptivePortalAuthenticationIgnoresProxy,
+                  POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                   POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                  new base::StringValue("primary-only"),
-                  nullptr);
-  policy_map->Set(key::kEasyUnlockAllowed,
-                  POLICY_LEVEL_MANDATORY,
-                  POLICY_SCOPE_USER,
+                  base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+  policy_map->Set(key::kAllowDinosaurEasterEgg, POLICY_LEVEL_MANDATORY,
+                  POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
+                  base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+  policy_map->Set(key::kArcEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                   POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                  new base::FundamentalValue(false),
-                  nullptr);
-  policy_map->Set(key::kCaptivePortalAuthenticationIgnoresProxy,
-                  POLICY_LEVEL_MANDATORY,
-                  POLICY_SCOPE_USER,
-                  POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                  new base::FundamentalValue(false),
-                  nullptr);
-  policy_map->Set(key::kAllowDinosaurEasterEgg,
-                  POLICY_LEVEL_MANDATORY,
-                  POLICY_SCOPE_USER,
-                  POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                  new base::FundamentalValue(false),
-                  nullptr);
-  policy_map->Set(key::kArcEnabled,
-                  POLICY_LEVEL_MANDATORY,
-                  POLICY_SCOPE_USER,
-                  POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                  new base::FundamentalValue(false),
-                  nullptr);
+                  base::WrapUnique(new base::FundamentalValue(false)), nullptr);
 #endif
 }
 
 void GetExpectedTestPolicy(PolicyMap* expected, const char* homepage) {
-  expected->Set(key::kShowHomeButton,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
+  expected->Set(key::kShowHomeButton, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                 POLICY_SOURCE_CLOUD,
-                new base::FundamentalValue(true),
-                nullptr);
-  expected->Set(key::kRestoreOnStartup,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_CLOUD,
-                new base::FundamentalValue(4),
-                nullptr);
+                base::WrapUnique(new base::FundamentalValue(true)), nullptr);
+  expected->Set(key::kRestoreOnStartup, POLICY_LEVEL_MANDATORY,
+                POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+                base::WrapUnique(new base::FundamentalValue(4)), nullptr);
   base::ListValue list;
   list.AppendString("dev.chromium.org");
   list.AppendString("youtube.com");
-  expected->Set(key::kURLBlacklist,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_CLOUD,
-                list.DeepCopy(),
+  expected->Set(key::kURLBlacklist, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+                POLICY_SOURCE_CLOUD, list.CreateDeepCopy(), nullptr);
+  expected->Set(key::kMaxInvalidationFetchDelay, POLICY_LEVEL_MANDATORY,
+                POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+                base::WrapUnique(new base::FundamentalValue(1000)), nullptr);
+  expected->Set(key::kHomepageLocation, POLICY_LEVEL_RECOMMENDED,
+                POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
+                base::WrapUnique(new base::StringValue(homepage)), nullptr);
+#if defined(OS_CHROMEOS)
+  expected->Set(key::kChromeOsMultiProfileUserBehavior, POLICY_LEVEL_MANDATORY,
+                POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
+                base::WrapUnique(new base::StringValue("primary-only")),
                 nullptr);
-  expected->Set(key::kMaxInvalidationFetchDelay,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_CLOUD,
-                new base::FundamentalValue(1000),
-                nullptr);
-  expected->Set(key::kHomepageLocation,
-                POLICY_LEVEL_RECOMMENDED,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_CLOUD,
-                new base::StringValue(homepage),
-                nullptr);
-#if defined(OS_CHROMEOS)
-  expected->Set(key::kChromeOsMultiProfileUserBehavior,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
+  expected->Set(key::kEasyUnlockAllowed, POLICY_LEVEL_MANDATORY,
+                POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
+                base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+  expected->Set(key::kCaptivePortalAuthenticationIgnoresProxy,
+                POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                 POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                new base::StringValue("primary-only"),
-                nullptr);
-  expected->Set(key::kEasyUnlockAllowed,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
+                base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+  expected->Set(key::kAllowDinosaurEasterEgg, POLICY_LEVEL_MANDATORY,
+                POLICY_SCOPE_USER, POLICY_SOURCE_ENTERPRISE_DEFAULT,
+                base::WrapUnique(new base::FundamentalValue(false)), nullptr);
+  expected->Set(key::kArcEnabled, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                 POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                new base::FundamentalValue(false),
-                nullptr);
-  expected->Set(key::kCaptivePortalAuthenticationIgnoresProxy,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                new base::FundamentalValue(false),
-                nullptr);
-  expected->Set(key::kAllowDinosaurEasterEgg,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                new base::FundamentalValue(false),
-                nullptr);
-  expected->Set(key::kArcEnabled,
-                POLICY_LEVEL_MANDATORY,
-                POLICY_SCOPE_USER,
-                POLICY_SOURCE_ENTERPRISE_DEFAULT,
-                new base::FundamentalValue(false),
-                nullptr);
+                base::WrapUnique(new base::FundamentalValue(false)), nullptr);
 #endif
 }
 
 }  // namespace
 
 // Tests the cloud policy stack(s).
 class CloudPolicyTest : public InProcessBrowserTest,
                         public PolicyService::Observer {
  protected:
   CloudPolicyTest() {}
@@ skipping 283 matching lines @@
 
   // They should now serialize to the same bytes.
   std::string chrome_settings_serialized;
   std::string cloud_policy_serialized;
   ASSERT_TRUE(chrome_settings.SerializeToString(&chrome_settings_serialized));
   ASSERT_TRUE(cloud_policy.SerializeToString(&cloud_policy_serialized));
   EXPECT_EQ(chrome_settings_serialized, cloud_policy_serialized);
 }
 
 }  // namespace policy