Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/storage/policy_value_store.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/files/file_path.h"
@@ skipping 107 matching lines @@
   std::unique_ptr<PolicyValueStore> store_;
   MockSettingsObserver observer_;
   scoped_refptr<SettingsObserverList> observers_;
 };
 
 TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {
   policy::PolicyMap policies;
   base::FundamentalValue expected(123);
   policies.Set("must", policy::POLICY_LEVEL_MANDATORY,
                policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
-               expected.DeepCopy(), nullptr);
+               expected.CreateDeepCopy(), nullptr);
   policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,
                policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
-               new base::FundamentalValue(456), NULL);
+               base::WrapUnique(new base::FundamentalValue(456)), nullptr);
   store_->SetCurrentPolicy(policies);
   ValueStore::ReadResult result = store_->Get();
   ASSERT_TRUE(result->status().ok());
   EXPECT_EQ(1u, result->settings().size());
   base::Value* value = NULL;
   EXPECT_FALSE(result->settings().Get("may", &value));
   EXPECT_TRUE(result->settings().Get("must", &value));
   EXPECT_TRUE(base::Value::Equals(&expected, value));
 }
 
@@ skipping 21 matching lines @@
     ValueStoreChangeList changes;
     changes.push_back(ValueStoreChange("aaa", nullptr, value.CreateDeepCopy()));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policy::PolicyMap policies;
   policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);
+               policy::POLICY_SOURCE_CLOUD, value.CreateDeepCopy(), nullptr);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when new policies are added.
   {
     ValueStoreChangeList changes;
     changes.push_back(ValueStoreChange("bbb", nullptr, value.CreateDeepCopy()));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);
+               policy::POLICY_SOURCE_CLOUD, value.CreateDeepCopy(), nullptr);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when policies change.
   const base::StringValue new_value("222");
   {
     ValueStoreChangeList changes;
     changes.push_back(ValueStoreChange("bbb", value.CreateDeepCopy(),
                                        new_value.CreateDeepCopy()));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,
-               policy::POLICY_SOURCE_CLOUD, new_value.DeepCopy(), nullptr);
+               policy::POLICY_SOURCE_CLOUD, new_value.CreateDeepCopy(),
+               nullptr);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Notify when policies are removed.
   {
     ValueStoreChangeList changes;
     changes.push_back(
         ValueStoreChange("bbb", new_value.CreateDeepCopy(), nullptr));
     EXPECT_CALL(observer_,
                 OnSettingsChanged(kTestExtensionId,
                                   settings_namespace::MANAGED,
                                   ValueStoreChange::ToJson(changes)));
   }
 
   policies.Erase("bbb");
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 
   // Don't notify when there aren't any changes.
   EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);
   store_->SetCurrentPolicy(policies);
   loop_.RunUntilIdle();
   Mock::VerifyAndClearExpectations(&observer_);
 }
 
 }  // namespace extensions