chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc ('k') | chrome/browser/extensions/api/storage/policy_value_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

index 1b1e04a572806b6e6cfdfca7bc002b17a09dc5b1..b7d59f7a872a693c8aa830b70d9d499d7a2dc81e 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

@@ -595,10 +595,10 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, GetManagedProperties) {

"}";

policy::PolicyMap policy;

- policy.Set(policy::key::kOpenNetworkConfiguration,

- policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD,

- new base::StringValue(user_policy_blob), nullptr);

+ policy.Set(

+ policy::key::kOpenNetworkConfiguration, policy::POLICY_LEVEL_MANDATORY,

+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

+ base::WrapUnique(new base::StringValue(user_policy_blob)), nullptr);

provider_.UpdateChromePolicy(policy);

content::RunAllPendingInMessageLoop();