chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc ('k') | chrome/browser/chromeos/login/saml/saml_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

diff --git a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

index 0851c9cc78782707f0e64a182ab2aea2e891e262..96be7de4af904b41661bde614e93b09ed823a07f 100644

--- a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

+++ b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h"

#include <string>

+#include <utility>

#include "base/callback.h"

#include "base/files/file_util.h"

@@ -183,10 +184,8 @@ void DeviceLocalAccountExternalPolicyLoaderTest::SetForceInstallListPolicy() {

extension_urls::GetWebstoreUpdateUrl().spec().c_str()));

store_.policy_map_.Set(policy::key::kExtensionInstallForcelist,

policy::POLICY_LEVEL_MANDATORY,

- policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD,

- forcelist.release(),

- NULL);

+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

+ std::move(forcelist), nullptr);

store_.NotifyStoreLoaded();

}