chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc ('k') | chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h

diff --git a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h

index 8ddbeb169b2e8278da081653d7544cc51b6526cf..9081dddef236a7fcb58c3070d194ccf4c371341b 100644

--- a/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h

+++ b/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h

@@ -65,7 +65,8 @@ class NetworkConfigurationPolicyHandler : public TypeCheckingPolicyHandler {

// that contains a pretty-printed and sanitized version. In particular, we

// remove any Passphrases that may be contained in the JSON. Ownership of the

// return value is transferred to the caller.

- static base::Value* SanitizeNetworkConfig(const base::Value* config);

+ static std::unique_ptr<base::Value> SanitizeNetworkConfig(

+ const base::Value* config);

// The kind of ONC source that this handler represents. ONCSource

// distinguishes between user and device policy.