components/policy/core/common/cloud/component_cloud_policy_store.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_store.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc ('k') | components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/component_cloud_policy_store.cc

diff --git a/components/policy/core/common/cloud/component_cloud_policy_store.cc b/components/policy/core/common/cloud/component_cloud_policy_store.cc

index 5a07ca41d74457a411cb0bd829c0f5dd33ae9cc2..f881398f77bfbc91db1f66e9622f1b8414975fc6 100644

--- a/components/policy/core/common/cloud/component_cloud_policy_store.cc

+++ b/components/policy/core/common/cloud/component_cloud_policy_store.cc

@@ -360,7 +360,7 @@ bool ComponentCloudPolicyStore::ParsePolicy(const std::string& data,

// this must support a configurable scope; assuming POLICY_SCOPE_USER is

// fine for now.

policy->Set(it.key(), level, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- value.release(), nullptr);

+ std::move(value), nullptr);

}

return true;