chrome/browser/errorpage_browsertest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/errorpage_browsertest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: another-fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_dir_policy_handler_unittest.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/errorpage_browsertest.cc

diff --git a/chrome/browser/errorpage_browsertest.cc b/chrome/browser/errorpage_browsertest.cc

index eddd55d41b637cca1632b1ae39cd8f8216d46d9e..accff8c174923460451e73c91ee2b47da72aaaee 100644

--- a/chrome/browser/errorpage_browsertest.cc

+++ b/chrome/browser/errorpage_browsertest.cc

@@ -11,6 +11,7 @@

#include "base/files/scoped_temp_dir.h"

#include "base/logging.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "base/memory/weak_ptr.h"

#include "base/path_service.h"

#include "base/strings/stringprintf.h"

@@ -1287,7 +1288,8 @@ class ErrorPageOfflineTest : public ErrorPageTest {

policy_map.Set(

policy::key::kAllowDinosaurEasterEgg, policy::POLICY_LEVEL_MANDATORY,

policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

- new base::FundamentalValue(value_of_allow_dinosaur_easter_egg_),

+ base::WrapUnique(

+ new base::FundamentalValue(value_of_allow_dinosaur_easter_egg_)),

nullptr);

}

policy_provider_.UpdateChromePolicy(policy_map);