Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1428543003: Create GLSL base class for ProgramDataManager (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create GLSL base class for ProgramDataManager BUG=skia: Committed: https://skia.googlesource.com/skia/+/018fb62d12d1febf121fe265da5b6117b86a6541

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : add space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -327 lines) Patch
M gm/dcshader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkLightingShader.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M src/effects/GrCircleBlurFragmentProcessor.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 5 chunks +10 lines, -9 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 3 chunks +6 lines, -5 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 16 chunks +22 lines, -21 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 4 chunks +7 lines, -6 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 11 chunks +17 lines, -16 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +12 lines, -9 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 6 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 5 chunks +9 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 7 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 5 chunks +13 lines, -10 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 5 chunks +11 lines, -10 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 5 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 5 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 4 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.h View 4 chunks +20 lines, -41 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 14 chunks +17 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
A src/gpu/glsl/GrGLSLProgramDataManager.h View 1 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
egdaniel
This creates a glsl base call of ProgramDataManager. This allows the setData function on all ...
5 years, 1 month ago (2015-10-27 21:08:06 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1428543003/diff/20001/include/gpu/gl/GrGLTypes.h File include/gpu/gl/GrGLTypes.h (left): https://codereview.chromium.org/1428543003/diff/20001/include/gpu/gl/GrGLTypes.h#oldcode1 include/gpu/gl/GrGLTypes.h:1: I dunno why, but I think all our ...
5 years, 1 month ago (2015-10-28 12:54:36 UTC) #3
egdaniel
https://codereview.chromium.org/1428543003/diff/20001/include/gpu/gl/GrGLTypes.h File include/gpu/gl/GrGLTypes.h (left): https://codereview.chromium.org/1428543003/diff/20001/include/gpu/gl/GrGLTypes.h#oldcode1 include/gpu/gl/GrGLTypes.h:1: On 2015/10/28 12:54:36, bsalomon wrote: > I dunno why, ...
5 years, 1 month ago (2015-10-28 14:14:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428543003/40001
5 years, 1 month ago (2015-10-28 14:15:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 14:26:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/018fb62d12d1febf121fe265da5b6117b86a6541

Powered by Google App Engine
This is Rietveld 408576698