Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132463007: Enable presubmit pylint in build/android. (Closed)

Created:
6 years, 10 months ago by jbudorick
Modified:
6 years, 10 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, bruening+watch_chromium.org, glider+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable presubmit pylint in build/android. BUG=168518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249793

Patch Set 1 #

Total comments: 20

Patch Set 2 : Address frankf review comments. #

Total comments: 1

Patch Set 3 : Move disables into modules. #

Total comments: 4

Patch Set 4 : rebase vs tot and only disabling F0401 in specific spots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -357 lines) Patch
M build/android/PRESUBMIT.py View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M build/android/adb_logcat_monitor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/adb_logcat_printer.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/android/adb_profile_chrome.py View 1 4 chunks +3 lines, -4 lines 0 comments Download
M build/android/asan_symbolize.py View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M build/android/avd.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M build/android/bb_run_sharded_steps.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M build/android/findbugs_diff.py View 1 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/generate_emma_html.py View 1 4 chunks +3 lines, -4 lines 0 comments Download
M build/android/gyp/ant.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/apk_install.py View 1 2 3 4 chunks +6 lines, -3 lines 0 comments Download
M build/android/gyp/create_device_library_links.py View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/create_native_libraries_header.py View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/create_standalone_apk.py View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M build/android/gyp/dex.py View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M build/android/gyp/emma_instr.py View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/gyp/finalize_apk.py View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/gyp/gcc_preprocess.py View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M build/android/gyp/generate_v14_compatible_resources.py View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M build/android/gyp/get_device_configuration.py View 1 2 3 1 chunk +2 lines, -8 lines 0 comments Download
M build/android/gyp/jar.py View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M build/android/gyp/jar_toc.py View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M build/android/gyp/javac.py View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M build/android/gyp/lint.py View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/gyp/process_resources.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/proguard.py View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M build/android/gyp/push_libraries.py View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M build/android/gyp/strip_library_for_device.py View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 2 3 3 chunks +4 lines, -6 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 5 chunks +11 lines, -9 lines 0 comments Download
M build/android/gyp/util/md5_check.py View 3 chunks +12 lines, -2 lines 0 comments Download
M build/android/gyp/util/md5_check_test.py View 1 chunk +4 lines, -0 lines 0 comments Download
M build/android/gyp/write_ordered_libraries.py View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M build/android/host_heartbeat.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/android/install_emulator_deps.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/lighttpd_server.py View 3 chunks +6 lines, -3 lines 0 comments Download
M build/android/lint/suppress.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 3 17 chunks +24 lines, -19 lines 0 comments Download
M build/android/pylib/base/base_test_result_unittest.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/base/base_test_runner.py View 2 chunks +1 line, -6 lines 0 comments Download
M build/android/pylib/base/test_dispatcher.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/pylib/base/test_dispatcher_unittest.py View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M build/android/pylib/chrome_test_server_spawner.py View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M build/android/pylib/cmd_helper.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/device/adb_wrapper_test.py View 1 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/flag_changer.py View 2 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/forwarder.py View 1 2 5 chunks +8 lines, -10 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M build/android/pylib/gtest/test_package.py View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/host_driven/setup.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/host_driven/test_case.py View 4 chunks +17 lines, -15 lines 0 comments Download
M build/android/pylib/host_driven/test_info_collection.py View 1 4 chunks +7 lines, -4 lines 0 comments Download
M build/android/pylib/host_driven/test_runner.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/host_driven/tests_annotations.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/instrumentation/json_perf_parser.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/setup.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/test_package.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 2 3 6 chunks +13 lines, -13 lines 0 comments Download
M build/android/pylib/linker/setup.py View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 1 2 6 chunks +18 lines, -20 lines 0 comments Download
M build/android/pylib/linker/test_runner.py View 1 1 chunk +1 line, -3 lines 0 comments Download
M build/android/pylib/monkey/setup.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/setup.py View 1 2 chunks +2 lines, -7 lines 0 comments Download
M build/android/pylib/perf/surface_stats_collector.py View 2 chunks +3 lines, -2 lines 0 comments Download
M build/android/pylib/perf/surface_stats_collector_unittest.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 2 chunks +14 lines, -7 lines 0 comments Download
M build/android/pylib/pexpect.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/ports.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/screenshot.py View 1 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/pylib/system_properties.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/uiautomator/setup.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 6 chunks +8 lines, -8 lines 0 comments Download
M build/android/pylib/utils/findbugs.py View 4 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/utils/flakiness_dashboard_results_uploader.py View 1 2 3 4 chunks +5 lines, -3 lines 0 comments Download
M build/android/pylib/utils/report_results.py View 1 2 chunks +6 lines, -7 lines 0 comments Download
M build/android/pylib/utils/reraiser_thread.py View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M build/android/pylib/utils/reraiser_thread_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/utils/timeout_retry.py View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M build/android/pylib/utils/timeout_retry_unittest.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/utils/xvfb.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 1 2 3 5 chunks +13 lines, -7 lines 0 comments Download
M build/android/surface_stats.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/symbolize_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.py View 10 chunks +12 lines, -13 lines 0 comments Download
M build/android/tombstones.py View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jbudorick
Apologies for the size of this one.
6 years, 10 months ago (2014-01-29 14:24:02 UTC) #1
frankf
Excellent, thanks John. Some comments. https://codereview.chromium.org/132463007/diff/1/build/android/PRESUBMIT.py File build/android/PRESUBMIT.py (right): https://codereview.chromium.org/132463007/diff/1/build/android/PRESUBMIT.py#newcode39 build/android/PRESUBMIT.py:39: # C0301 - line ...
6 years, 10 months ago (2014-02-03 18:58:50 UTC) #2
jbudorick
https://codereview.chromium.org/132463007/diff/1/build/android/PRESUBMIT.py File build/android/PRESUBMIT.py (right): https://codereview.chromium.org/132463007/diff/1/build/android/PRESUBMIT.py#newcode39 build/android/PRESUBMIT.py:39: # C0301 - line length > 80 chars On ...
6 years, 10 months ago (2014-02-03 19:33:56 UTC) #3
jbudorick
Addressed Frank's comments.
6 years, 10 months ago (2014-02-03 21:10:59 UTC) #4
frankf
https://codereview.chromium.org/132463007/diff/100001/build/android/PRESUBMIT.py File build/android/PRESUBMIT.py (right): https://codereview.chromium.org/132463007/diff/100001/build/android/PRESUBMIT.py#newcode46 build/android/PRESUBMIT.py:46: warning_exemptions = { is it possible to disable these ...
6 years, 10 months ago (2014-02-03 21:16:37 UTC) #5
jbudorick
Moved the pylint disables into the modules.
6 years, 10 months ago (2014-02-03 21:45:20 UTC) #6
frankf
lgtm with nits Make sure to also run tests not running on trybots (linker, monkey, ...
6 years, 10 months ago (2014-02-03 21:49:30 UTC) #7
jbudorick
https://codereview.chromium.org/132463007/diff/470001/build/android/PRESUBMIT.py File build/android/PRESUBMIT.py (right): https://codereview.chromium.org/132463007/diff/470001/build/android/PRESUBMIT.py#newcode42 build/android/PRESUBMIT.py:42: black_list=[r'pylib/android_commands\.py$'], On 2014/02/03 21:49:30, frankf wrote: > could you ...
6 years, 10 months ago (2014-02-03 21:53:51 UTC) #8
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 10 months ago (2014-02-07 17:53:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/132463007/740001
6 years, 10 months ago (2014-02-07 17:53:25 UTC) #10
commit-bot: I haz the power
Change committed as 249793
6 years, 10 months ago (2014-02-07 21:34:28 UTC) #11
jbudorick
6 years, 10 months ago (2014-02-11 01:15:15 UTC) #12
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/153743008/ by jbudorick@chromium.org.

The reason for reverting is: This patch is probably the cause of
crbug.com/342539..

Powered by Google App Engine
This is Rietveld 408576698