build/android/pylib/uiautomator/setup.py - Issue 132463007: Enable presubmit pylint in build/android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/uiautomator/setup.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/android/pylib/system_properties.py ('k') | build/android/pylib/utils/emulator.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Generates test runner factory and tests for uiautomator tests."""	5 """Generates test runner factory and tests for uiautomator tests."""

6	6

7 import logging	7 import logging

8	8

9 import test_package	9 from pylib.uiautomator import test_package

10 import test_runner	10 from pylib.uiautomator import test_runner

11	11

12	12

13 def Setup(test_options):	13 def Setup(test_options):

14 """Runs uiautomator tests on connected device(s).	14 """Runs uiautomator tests on connected device(s).

15	15

16 Args:	16 Args:

17 test_options: A UIAutomatorOptions object.	17 test_options: A UIAutomatorOptions object.

18	18

19 Returns:	19 Returns:

20 A tuple of (TestRunnerFactory, tests).	20 A tuple of (TestRunnerFactory, tests).

21 """	21 """

22 test_pkg = test_package.TestPackage(test_options.uiautomator_jar,	22 test_pkg = test_package.TestPackage(test_options.uiautomator_jar,

23 test_options.uiautomator_info_jar)	23 test_options.uiautomator_info_jar)

24 tests = test_pkg._GetAllMatchingTests(test_options.annotations,	24 tests = test_pkg.GetAllMatchingTests(test_options.annotations,

25 test_options.exclude_annotations,	25 test_options.exclude_annotations,

26 test_options.test_filter)	26 test_options.test_filter)

27	27

28 if not tests:	28 if not tests:

29 logging.error('No uiautomator tests to run with current args.')	29 logging.error('No uiautomator tests to run with current args.')

30	30

31 def TestRunnerFactory(device, shard_index):	31 def TestRunnerFactory(device, shard_index):

32 return test_runner.TestRunner(	32 return test_runner.TestRunner(

33 test_options, device, shard_index, test_pkg)	33 test_options, device, shard_index, test_pkg)

34	34

35 return (TestRunnerFactory, tests)	35 return (TestRunnerFactory, tests)

OLD	NEW