OLD | NEW |
---|---|
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Presubmit script for android buildbot. | 5 """Presubmit script for android buildbot. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
8 details on the presubmit API built into gcl. | 8 details on the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 20 matching lines...) Expand all Loading... | |
31 def CommonChecks(input_api, output_api): | 31 def CommonChecks(input_api, output_api): |
32 output = [] | 32 output = [] |
33 | 33 |
34 def J(*dirs): | 34 def J(*dirs): |
35 """Returns a path relative to presubmit directory.""" | 35 """Returns a path relative to presubmit directory.""" |
36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) | 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) |
37 | 37 |
38 output.extend(input_api.canned_checks.RunPylint( | 38 output.extend(input_api.canned_checks.RunPylint( |
39 input_api, | 39 input_api, |
40 output_api, | 40 output_api, |
41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'], | 41 white_list=[r'.*\.py$'], |
42 black_list=[r'pylib/android_commands\.py$'], | |
frankf
2014/02/03 21:49:30
could you also do this in the code?
jbudorick
2014/02/03 21:53:52
Yes, but ignoring files is kind of the point of th
| |
43 disabled_warnings=['F0401'], | |
frankf
2014/02/03 21:49:30
why disable this?
jbudorick
2014/02/03 21:53:52
It doesn't seem to work correctly.
| |
42 extra_paths_list=[ | 44 extra_paths_list=[ |
43 J(), J('..', '..', 'third_party', 'android_testrunner'), | 45 J(), J('..', '..', 'third_party', 'android_testrunner'), |
44 J('buildbot')])) | 46 J('buildbot')])) |
45 | 47 |
46 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( | 48 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( |
47 input_api, output_api, J('buildbot', 'tests'))) | 49 input_api, output_api, J('buildbot', 'tests'))) |
48 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) | 50 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) |
49 return output | 51 return output |
50 | 52 |
51 | 53 |
52 def CheckChangeOnUpload(input_api, output_api): | 54 def CheckChangeOnUpload(input_api, output_api): |
53 return CommonChecks(input_api, output_api) | 55 return CommonChecks(input_api, output_api) |
54 | 56 |
55 | 57 |
56 def CheckChangeOnCommit(input_api, output_api): | 58 def CheckChangeOnCommit(input_api, output_api): |
57 return CommonChecks(input_api, output_api) | 59 return CommonChecks(input_api, output_api) |
OLD | NEW |