build/android/gyp/gcc_preprocess.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/gcc_preprocess.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/gcc_preprocess.py

diff --git a/build/android/gyp/gcc_preprocess.py b/build/android/gyp/gcc_preprocess.py

index 25192546053e181d35322a0d34887dd4dbe280a6..a5d4ba558488e85d42b078fcefef1ff9c6858464 100755

--- a/build/android/gyp/gcc_preprocess.py

+++ b/build/android/gyp/gcc_preprocess.py

@@ -6,10 +6,9 @@

import optparse

import os

-import subprocess

import sys

-from util import build_utils

+from util import build_utils # pylint: disable=F0401

def DoGcc(options):

build_utils.MakeDirectory(os.path.dirname(options.output))

@@ -30,7 +29,7 @@ def DoGcc(options):

build_utils.CheckOutput(gcc_cmd)

-def main(argv):

+def main():

parser = optparse.OptionParser()

parser.add_option('--include-path', help='Include path for gcc.')

parser.add_option('--template', help='Path to template.')

@@ -50,4 +49,4 @@ def main(argv):

if __name__ == '__main__':

- sys.exit(main(sys.argv))

+ sys.exit(main())