Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: build/android/pylib/perf/thermal_throttle.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/perf/test_runner.py ('k') | build/android/pylib/pexpect.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/perf/thermal_throttle.py
diff --git a/build/android/pylib/perf/thermal_throttle.py b/build/android/pylib/perf/thermal_throttle.py
index 6a47319f9838a3c2f8ce5527980b250cc74a659c..58281122081139c2484c58e925b680c201d3e2fd 100644
--- a/build/android/pylib/perf/thermal_throttle.py
+++ b/build/android/pylib/perf/thermal_throttle.py
@@ -17,13 +17,16 @@ class OmapThrottlingDetector(object):
def __init__(self, adb):
self._adb = adb
- def BecameThrottled(self, log_line):
+ @staticmethod
+ def BecameThrottled(log_line):
return 'omap_thermal_throttle' in log_line
- def BecameUnthrottled(self, log_line):
+ @staticmethod
+ def BecameUnthrottled(log_line):
return 'omap_thermal_unthrottle' in log_line
- def GetThrottlingTemperature(self, log_line):
+ @staticmethod
+ def GetThrottlingTemperature(log_line):
if 'throttle_delayed_work_fn' in log_line:
return float([s for s in log_line.split() if s.isdigit()][0]) / 1000.0
@@ -41,16 +44,20 @@ class ExynosThrottlingDetector(object):
def __init__(self, adb):
pass
- def BecameThrottled(self, log_line):
+ @staticmethod
+ def BecameThrottled(log_line):
return 'exynos_tmu: Throttling interrupt' in log_line
- def BecameUnthrottled(self, log_line):
+ @staticmethod
+ def BecameUnthrottled(log_line):
return 'exynos_thermal_unthrottle: not throttling' in log_line
- def GetThrottlingTemperature(self, log_line):
+ @staticmethod
+ def GetThrottlingTemperature(_log_line):
return None
- def GetCurrentTemperature(self):
+ @staticmethod
+ def GetCurrentTemperature():
return None
« no previous file with comments | « build/android/pylib/perf/test_runner.py ('k') | build/android/pylib/pexpect.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698