Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: build/android/gyp/jar_toc.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/jar.py ('k') | build/android/gyp/javac.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Creates a TOC file from a Java jar. 7 """Creates a TOC file from a Java jar.
8 8
9 The TOC file contains the non-package API of the jar. This includes all 9 The TOC file contains the non-package API of the jar. This includes all
10 public/protected classes/functions/members and the values of static final 10 public/protected classes/functions/members and the values of static final
11 variables. Some other information (major/minor javac version) is also included. 11 variables. Some other information (major/minor javac version) is also included.
12 12
13 This TOC file then can be used to determine if a dependent library should be 13 This TOC file then can be used to determine if a dependent library should be
14 rebuilt when this jar changes. I.e. any change to the jar that would require a 14 rebuilt when this jar changes. I.e. any change to the jar that would require a
15 rebuild, will have a corresponding change in the TOC file. 15 rebuild, will have a corresponding change in the TOC file.
16 """ 16 """
17 17
18 import optparse 18 import optparse
19 import os
20 import re 19 import re
21 import sys 20 import sys
22 import zipfile 21 import zipfile
23 22
23 # pylint: disable=F0401
24 from util import build_utils 24 from util import build_utils
25 from util import md5_check 25 from util import md5_check
26 # pylint: enable=F0401
26 27
27 28
28 def GetClassesInZipFile(zip_file): 29 def GetClassesInZipFile(zip_file):
29 classes = [] 30 classes = []
30 files = zip_file.namelist() 31 files = zip_file.namelist()
31 for f in files: 32 for f in files:
32 if f.endswith('.class'): 33 if f.endswith('.class'):
33 # f is of the form org/chromium/base/Class$Inner.class 34 # f is of the form org/chromium/base/Class$Inner.class
34 classes.append(f.replace('/', '.')[:-6]) 35 classes.append(f.replace('/', '.')[:-6])
35 return classes 36 return classes
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 toc_path = options.toc_path 83 toc_path = options.toc_path
83 record_path = '%s.md5.stamp' % toc_path 84 record_path = '%s.md5.stamp' % toc_path
84 md5_check.CallAndRecordIfStale( 85 md5_check.CallAndRecordIfStale(
85 lambda: UpdateToc(jar_path, toc_path), 86 lambda: UpdateToc(jar_path, toc_path),
86 record_path=record_path, 87 record_path=record_path,
87 input_paths=[jar_path], 88 input_paths=[jar_path],
88 ) 89 )
89 build_utils.Touch(toc_path) 90 build_utils.Touch(toc_path)
90 91
91 92
92 def main(argv): 93 def main():
93 parser = optparse.OptionParser() 94 parser = optparse.OptionParser()
94 parser.add_option('--jar-path', help='Input .jar path.') 95 parser.add_option('--jar-path', help='Input .jar path.')
95 parser.add_option('--toc-path', help='Output .jar.TOC path.') 96 parser.add_option('--toc-path', help='Output .jar.TOC path.')
96 parser.add_option('--stamp', help='Path to touch on success.') 97 parser.add_option('--stamp', help='Path to touch on success.')
97 98
98 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. 99 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
99 parser.add_option('--ignore', help='Ignored.') 100 parser.add_option('--ignore', help='Ignored.')
100 101
101 options, _ = parser.parse_args() 102 options, _ = parser.parse_args()
102 103
103 DoJarToc(options) 104 DoJarToc(options)
104 105
105 if options.stamp: 106 if options.stamp:
106 build_utils.Touch(options.stamp) 107 build_utils.Touch(options.stamp)
107 108
108 109
109 if __name__ == '__main__': 110 if __name__ == '__main__':
110 sys.exit(main(sys.argv)) 111 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/gyp/jar.py ('k') | build/android/gyp/javac.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698