Enable presubmit pylint in build/android.

build/android/asan_symbolize.py

 #!/usr/bin/env python
 #
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 import collections
 import optparse
 import os
@@ skipping 34 matching lines @@
   return asan_libs
 
 
 def _TranslateLibPath(library, asan_libs):
   for asan_lib in asan_libs:
     if os.path.basename(library) == os.path.basename(asan_lib):
       return '/' + asan_lib
   return symbol.TranslateLibPath(library)
 
 
-def _Symbolize(input):
+def _Symbolize(asan_input):
   asan_libs = _FindASanLibraries()
   libraries = collections.defaultdict(list)
   asan_lines = []
-  for asan_log_line in [a.strip() for a in input]:
+  for asan_log_line in [a.strip() for a in asan_input]:
     m = _ParseAsanLogLine(asan_log_line)
     if m:
       libraries[m['library']].append(m)
     asan_lines.append({'raw_log': asan_log_line, 'parsed': m})
 
   all_symbols = collections.defaultdict(dict)
-  original_symbols_dir = symbol.SYMBOLS_DIR
   for library, items in libraries.iteritems():
     libname = _TranslateLibPath(library, asan_libs)
     lib_relative_addrs = set([i['rel_address'] for i in items])
     info_dict = symbol.SymbolInformationForSet(libname,
                                                lib_relative_addrs,
                                                True)
     if info_dict:
       all_symbols[library]['symbols'] = info_dict
 
   for asan_log_line in asan_lines:
     m = asan_log_line['parsed']
     if not m:
       print asan_log_line['raw_log']
       continue
     if (m['library'] in all_symbols and
         m['rel_address'] in all_symbols[m['library']]['symbols']):
       s = all_symbols[m['library']]['symbols'][m['rel_address']][0]
       print s[0], s[1], s[2]
     else:
       print asan_log_line['raw_log']
 
 
 def main():
   parser = optparse.OptionParser()
   parser.add_option('-l', '--logcat',
                     help='File containing adb logcat output with ASan stacks. '
                          'Use stdin if not specified.')
-  options, args = parser.parse_args()
+  options, _args = parser.parse_args()

[frankf, 2014/02/03 18:58:51]

^

[jbudorick, 2014/02/03 19:33:57]

Done.

   if options.logcat:
-    input = file(options.logcat, 'r')
+    asan_input = file(options.logcat, 'r')
   else:
-    input = sys.stdin
-  _Symbolize(input.readlines())
+    asan_input = sys.stdin
+  _Symbolize(asan_input.readlines())
 
 
 if __name__ == "__main__":
   sys.exit(main())