Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: build/android/gyp/util/build_device.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/strip_library_for_device.py ('k') | build/android/gyp/util/build_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/util/build_device.py
diff --git a/build/android/gyp/util/build_device.py b/build/android/gyp/util/build_device.py
index 11f6277453ba67dbf0dec15517f09c6a2721169b..03d5f2a275a86f2519f5161694453ca8131ac45c 100644
--- a/build/android/gyp/util/build_device.py
+++ b/build/android/gyp/util/build_device.py
@@ -11,15 +11,13 @@ import os
import re
import sys
-import build_utils
+import build_utils # pylint: disable=F0401
BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..', '..')
sys.path.append(BUILD_ANDROID_DIR)
from pylib import android_commands
-from pylib.android_commands import GetAttachedDevices
-
class BuildDevice(object):
def __init__(self, configuration):
@@ -52,8 +50,8 @@ class BuildDevice(object):
return matches[0] if matches else None
-def GetConfigurationForDevice(id):
- adb = android_commands.AndroidCommands(id)
+def GetConfigurationForDevice(device_id):
+ adb = android_commands.AndroidCommands(device_id)
configuration = None
has_root = False
is_online = adb.IsOnline()
@@ -69,7 +67,7 @@ def GetConfigurationForDevice(id):
cmd_output = adb.RunShellCommand(cmd)
configuration = {
- 'id': id,
+ 'id': device_id,
'description': cmd_output[-1],
'install_metadata': cmd_output[:-1],
}
« no previous file with comments | « build/android/gyp/strip_library_for_device.py ('k') | build/android/gyp/util/build_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698