build/android/pylib/gtest/test_package_exe.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/test_package_exe.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/test_package_exe.py

diff --git a/build/android/pylib/gtest/test_package_exe.py b/build/android/pylib/gtest/test_package_exe.py

index 5da86ba4c2061e309220ad352e6aff3dd566e4d3..02330f036f33c3df46e058464ed6a2d8154924bd 100644

--- a/build/android/pylib/gtest/test_package_exe.py

+++ b/build/android/pylib/gtest/test_package_exe.py

@@ -13,8 +13,7 @@ import tempfile

from pylib import cmd_helper

from pylib import constants

from pylib import pexpect

-from test_package import TestPackage

+from pylib.gtest.test_package import TestPackage

class TestPackageExecutable(TestPackage):

@@ -53,7 +52,8 @@ class TestPackageExecutable(TestPackage):

ret = 1

return ret

- def _AddNativeCoverageExports(self, adb):

+ @staticmethod

+ def _AddNativeCoverageExports(adb):

# export GCOV_PREFIX set the path for native coverage results

# export GCOV_PREFIX_STRIP indicates how many initial directory

# names to strip off the hardwired absolute paths.