Enable presubmit pylint in build/android.

build/android/PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for android buildbot.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into gcl.
 """
 
@@ skipping 17 matching lines @@
   return results
 
 
 def CommonChecks(input_api, output_api):
   output = []
 
   def J(*dirs):
     """Returns a path relative to presubmit directory."""
     return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
 
+  # warnings:
+  #   C0301 - line length > 80 chars

[frankf, 2014/02/03 18:58:51]

hmm, so why are these exempt? Is it just temporary to get pylint running?

[jbudorick, 2014/02/03 19:33:57]

No. The exemptions are all here because the scripts seemed to be correct as
implemented. The only thing that's exempt on a temporary basis is
android_commands.

 - C0301s are exempted in files with lines containing URLs.
 - E1002s are exempted in files containing a class that derives from a base
class that we don't control.
 - R0201s are exempted in files containing a class that have a virtual method
that doesn't use self.
 - W0212s are exempted in files containing a protected member access that seemed
to be "correct" (this one's a little squishy).
 - W0401 and W0614 are exempted in pexpect.py, which exists solely to pull in
everything from pexpect.
 - W0702s are exempted in files containing some functionality that really
doesn't want to let an exception escape.

+  #   E1002 - |super| on old-style class
+  #   R0201 - method could be a function
+  #   W0212 - protected member access
+  #   W0401 - wildcard import
+  #   W0614 - unused import
+  #   W0702 - bare-except ("except:")
+
+  warning_exemptions = {
+    r'adb_logcat_printer\.py$' : ['W0702'],
+    r'gyp/apk_install\.py$' : ['C0301'],
+    r'host_heartbeat\.py$' : ['W0702'],
+    r'install_emulator_deps\.py$' : ['C0301'],
+    r'pylib/base/test_dispatcher_unittest\.py$' : ['R0201','W0212'],
+    r'pylib/chrome_test_server_spawner\.py$' : ['W0702'],
+    r'pylib/constants\.py$' : ['W0212'],
+    r'pylib/forwarder\.py$' : ['W0212'],
+    r'pylib/gtest/setup\.py$' : ['W0212'],
+    r'pylib/gtest/test_package_apk\.py$' : ['W0212'],
+    r'pylib/gtest/test_package\.py$' : ['R0201'],
+    r'pylib/host_driven/tests_annotations\.py$' : ['W0212'],
+    r'pylib/instrumentation/test_jar\.py$' : ['W0702'],
+    r'pylib/linker/test_case\.py$' : ['R0201'],
+    r'pylib/perf/surface_stats_collector_unittest\.py$' : ['W0212'],
+    r'pylib/pexpect\.py$' : ['W0401','W0614'],
+    r'pylib/utils/reraiser_thread\.py$' : ['W0212'],
+    r'pylib/utils/flakiness_dashboard_results_uploader\.py$' :
+        ['E1002','R0201'],
+    r'pylib/valgrind_tools\.py$' : ['R0201'],
+    r'pylib/utils/timeout_retry\.py$' : ['W0702'],
+    r'pylib/utils/xvfb\.py$' : ['W0702']
+  }
+
+  all_disabled_warnings = ['F0401']
+  # exempt android_commands because it's a mess and will be replaced soon.
+  all_exempted_files = [r'pylib/android_commands\.py$']
+  for filename, warnings in warning_exemptions.items():
+    output.extend(input_api.canned_checks.RunPylint(
+        input_api,
+        output_api,
+        white_list=[filename],
+        disabled_warnings=list(all_disabled_warnings) + warnings))
+    all_exempted_files.append(filename)
+
   output.extend(input_api.canned_checks.RunPylint(
       input_api,
       output_api,
-      white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'],
+      white_list=[r'.*\.py$'],
+      black_list=all_exempted_files,
+      disabled_warnings=list(all_disabled_warnings),
       extra_paths_list=[
           J(), J('..', '..', 'third_party', 'android_testrunner'),
           J('buildbot')]))
 
   output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
       input_api, output_api, J('buildbot', 'tests')))
   output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))
   return output
 
 
 def CheckChangeOnUpload(input_api, output_api):
   return CommonChecks(input_api, output_api)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   return CommonChecks(input_api, output_api)