Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/adb_logcat_monitor.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl. 8 details on the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 17 matching lines...) Expand all
28 return results 28 return results
29 29
30 30
31 def CommonChecks(input_api, output_api): 31 def CommonChecks(input_api, output_api):
32 output = [] 32 output = []
33 33
34 def J(*dirs): 34 def J(*dirs):
35 """Returns a path relative to presubmit directory.""" 35 """Returns a path relative to presubmit directory."""
36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
37 37
38 # F0401 is issued when pylint can't import a module, but it doesn't seem to
39 # work correctly on our scripts.
38 output.extend(input_api.canned_checks.RunPylint( 40 output.extend(input_api.canned_checks.RunPylint(
39 input_api, 41 input_api,
40 output_api, 42 output_api,
41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'], 43 white_list=[r'.*\.py$'],
44 black_list=[r'pylib/android_commands\.py$'],
42 extra_paths_list=[ 45 extra_paths_list=[
43 J(), J('..', '..', 'third_party', 'android_testrunner'), 46 J(), J('..', '..', 'third_party', 'android_testrunner'),
44 J('buildbot')])) 47 J('buildbot')]))
45 48
46 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( 49 output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
47 input_api, output_api, J('buildbot', 'tests'))) 50 input_api, output_api, J('buildbot', 'tests')))
48 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) 51 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))
49 return output 52 return output
50 53
51 54
52 def CheckChangeOnUpload(input_api, output_api): 55 def CheckChangeOnUpload(input_api, output_api):
53 return CommonChecks(input_api, output_api) 56 return CommonChecks(input_api, output_api)
54 57
55 58
56 def CheckChangeOnCommit(input_api, output_api): 59 def CheckChangeOnCommit(input_api, output_api):
57 return CommonChecks(input_api, output_api) 60 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | build/android/adb_logcat_monitor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698