Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: build/android/pylib/instrumentation/test_jar.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/instrumentation/setup.py ('k') | build/android/pylib/instrumentation/test_package.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/test_jar.py
diff --git a/build/android/pylib/instrumentation/test_jar.py b/build/android/pylib/instrumentation/test_jar.py
index 21ce8402b15a8fd2e50c105f19caeae369b3b212..9df90fcb7c0a785131bba4f6ce1190c9028367ff 100644
--- a/build/android/pylib/instrumentation/test_jar.py
+++ b/build/android/pylib/instrumentation/test_jar.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
"""Helper class for instrumenation test jar."""
+# pylint: disable=W0702
import collections
import logging
@@ -127,7 +128,8 @@ class TestJar(object):
def _GetAnnotationMap(self):
return self._annotation_map
- def _IsTestMethod(self, test):
+ @staticmethod
+ def _IsTestMethod(test):
class_name, method = test.split('#')
return class_name.endswith('Test') and method.startswith('test')
@@ -137,7 +139,8 @@ class TestJar(object):
return []
return self._GetAnnotationMap()[test]
- def _AnnotationsMatchFilters(self, annotation_filter_list, annotations):
+ @staticmethod
+ def _AnnotationsMatchFilters(annotation_filter_list, annotations):
"""Checks if annotations match any of the filters."""
if not annotation_filter_list:
return True
@@ -173,7 +176,7 @@ class TestJar(object):
tests_missing_annotations.append(test_method)
return sorted(tests_missing_annotations)
- def _GetAllMatchingTests(self, annotation_filter_list,
+ def GetAllMatchingTests(self, annotation_filter_list,
exclude_annotation_list, test_filter):
"""Get a list of tests matching any of the annotations and the filter.
« no previous file with comments | « build/android/pylib/instrumentation/setup.py ('k') | build/android/pylib/instrumentation/test_package.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698