build/android/gyp/write_ordered_libraries.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/write_ordered_libraries.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/write_ordered_libraries.py

diff --git a/build/android/gyp/write_ordered_libraries.py b/build/android/gyp/write_ordered_libraries.py

index 23becb01e0403e4c8f7ab24a7af5485e785955be..27fbe76e8b6c22842981b4adf1301aef11c6dc02 100755

--- a/build/android/gyp/write_ordered_libraries.py

+++ b/build/android/gyp/write_ordered_libraries.py

@@ -20,13 +20,12 @@ libraries that should be included in the APK.

# gyp, rather than calculating it ourselves.

# http://crbug.com/225558

-import json

import optparse

import os

import re

import sys

-from util import build_utils

+from util import build_utils # pylint: disable=F0401

_options = None

_library_re = re.compile(

@@ -92,7 +91,7 @@ def GetSortedTransitiveDependenciesForExecutable(executable):

return GetSortedTransitiveDependencies(libraries)

-def main(argv):

+def main():

parser = optparse.OptionParser()

parser.add_option('--input-libraries',

@@ -120,6 +119,6 @@ def main(argv):

if __name__ == '__main__':

- sys.exit(main(sys.argv))

+ sys.exit(main())

« no previous file with comments | « build/android/gyp/util/md5_check_test.py ('k') | build/android/host_heartbeat.py » ('j') | no next file with comments »