Enable presubmit pylint in build/android.

build/android/pylib/utils/flakiness_dashboard_results_uploader.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Uploads the results to the flakiness dashboard server."""
+# pylint: disable=E1002,R0201
 
 import logging
 import os
 import shutil
-import subprocess
 import sys
 import tempfile
 import xml
 
 
 # Include path when ran from a Chromium checkout.
 sys.path.append(
     os.path.abspath(os.path.join(os.path.dirname(__file__),
                                  os.pardir, os.pardir, os.pardir, os.pardir,
                                  'third_party', 'WebKit', 'Tools', 'Scripts')))
 
 # Include path when ran from a WebKit checkout.
 sys.path.append(
     os.path.abspath(os.path.join(os.path.dirname(__file__),
                                  os.pardir, os.pardir, os.pardir, os.pardir,
                                  os.pardir, os.pardir, os.pardir,
                                  'Tools', 'Scripts')))
 
+# pylint: disable=F0401
 from webkitpy.common.system import executive, filesystem
 from webkitpy.layout_tests.layout_package import json_results_generator
+# pylint: enable=F0401
 
 #TODO(craigdh): pylib/utils/ should not depend on pylib/.
 from pylib import cmd_helper
 from pylib import constants
 from pylib.utils import repo_utils
 
 
 # The JSONResultsGenerator gets the filesystem.join operation from the Port
 # object. Creating a Port object requires specifying information that only
 # makes sense for running WebKit layout tests, so we provide a dummy object
@@ skipping 77 matching lines @@
 
     if not self._build_number or not self._builder_name:
       raise Exception('You should not be uploading tests results to the server'
                       'from your local machine.')
 
     upstream = (tests_type != 'Chromium_Android_Instrumentation')
     if upstream:
       # TODO(frankf): Use factory properties (see buildbot/bb_device_steps.py)
       # This requires passing the actual master name (e.g. 'ChromiumFYI' not
       # 'chromium.fyi').
-      from slave import slave_utils
+      from slave import slave_utils # pylint: disable=F0401
       self._build_name = slave_utils.SlaveBuildName(constants.DIR_SOURCE_ROOT)
       self._master_name = slave_utils.GetActiveMaster()
     else:
       self._build_name = 'chromium-android'
       buildbot_branch = os.environ.get('BUILDBOT_BRANCH')
       if not buildbot_branch:
         buildbot_branch = 'master'
       self._master_name = '%s-%s' % (self._build_name, buildbot_branch)
 
     self._test_results_map = {}
@@ skipping 42 matching lines @@
           test_results_map=self._test_results_map,
           test_results_server=test_results_server,
           test_type=self._tests_type,
           master_name=self._master_name)
 
       json_files = ["incremental_results.json", "times_ms.json"]
       results_generator.generate_json_output()
       results_generator.generate_times_ms_file()
       results_generator.upload_json_files(json_files)
     except Exception as e:
-      logging.error("Uploading results to test server failed: %s." % e);
+      logging.error("Uploading results to test server failed: %s." % e)
     finally:
       shutil.rmtree(tmp_folder)
 
 
 def Upload(results, flakiness_dashboard_server, test_type):
   """Reports test results to the flakiness dashboard for Chrome for Android.
 
   Args:
     results: test results.
     flakiness_dashboard_server: the server to upload the results to.
     test_type: the type of the tests (as displayed by the flakiness dashboard).
   """
   uploader = ResultsUploader(test_type)
   uploader.AddResults(results)
   uploader.Upload(flakiness_dashboard_server)