build/android/gyp/push_libraries.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/push_libraries.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/push_libraries.py

diff --git a/build/android/gyp/push_libraries.py b/build/android/gyp/push_libraries.py

index a2060c6655e1a879c16dfc67cbefddbf570a0a98..e8abe438ad0a3cfef654bad12143e9b1c1c9ffdc 100755

--- a/build/android/gyp/push_libraries.py

+++ b/build/android/gyp/push_libraries.py

@@ -8,7 +8,6 @@

"""

-import json

import optparse

import os

import sys

@@ -18,9 +17,11 @@ sys.path.append(BUILD_ANDROID_DIR)

from pylib import constants

+# pylint: disable=F0401

from util import build_device

from util import build_utils

from util import md5_check

+# pylint: disable=F0401

def DoPush(options):

libraries = build_utils.ReadJson(options.libraries_json)

@@ -51,7 +52,7 @@ def DoPush(options):

input_strings=[device_path])

-def main(argv):

+def main():

parser = optparse.OptionParser()

parser.add_option('--libraries-dir',

help='Directory that contains stripped libraries.')

@@ -77,4 +78,4 @@ def main(argv):

if __name__ == '__main__':

- sys.exit(main(sys.argv))

+ sys.exit(main())

« no previous file with comments | « build/android/gyp/proguard.py ('k') | build/android/gyp/strip_library_for_device.py » ('j') | no next file with comments »