Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Side by Side Diff: build/android/gyp/create_standalone_apk.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/create_native_libraries_header.py ('k') | build/android/gyp/dex.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Combines stripped libraries and incomplete APK into single standalone APK. 7 """Combines stripped libraries and incomplete APK into single standalone APK.
8 8
9 """ 9 """
10 10
11 import optparse 11 import optparse
12 import os 12 import os
13 import shutil 13 import shutil
14 import sys 14 import sys
15 import tempfile 15 import tempfile
16 16
17 # pylint: disable=F0401
17 from util import build_utils 18 from util import build_utils
18 from util import md5_check 19 from util import md5_check
20 # pylint: enable=F0401
19 21
20 def CreateStandaloneApk(options): 22 def CreateStandaloneApk(options):
21 def DoZip(): 23 def DoZip():
22 with tempfile.NamedTemporaryFile(suffix='.zip') as intermediate_file: 24 with tempfile.NamedTemporaryFile(suffix='.zip') as intermediate_file:
23 intermediate_path = intermediate_file.name 25 intermediate_path = intermediate_file.name
24 shutil.copy(options.input_apk_path, intermediate_path) 26 shutil.copy(options.input_apk_path, intermediate_path)
25 apk_path_abs = os.path.abspath(intermediate_path) 27 apk_path_abs = os.path.abspath(intermediate_path)
26 build_utils.CheckOutput( 28 build_utils.CheckOutput(
27 ['zip', '-r', '-1', apk_path_abs, 'lib'], 29 ['zip', '-r', '-1', apk_path_abs, 'lib'],
28 cwd=options.libraries_top_dir) 30 cwd=options.libraries_top_dir)
29 shutil.copy(intermediate_path, options.output_apk_path) 31 shutil.copy(intermediate_path, options.output_apk_path)
30 32
31 input_paths = [options.input_apk_path, options.libraries_top_dir] 33 input_paths = [options.input_apk_path, options.libraries_top_dir]
32 record_path = '%s.standalone.stamp' % options.input_apk_path 34 record_path = '%s.standalone.stamp' % options.input_apk_path
33 md5_check.CallAndRecordIfStale( 35 md5_check.CallAndRecordIfStale(
34 DoZip, 36 DoZip,
35 record_path=record_path, 37 record_path=record_path,
36 input_paths=input_paths) 38 input_paths=input_paths)
37 39
38 40
39 def main(argv): 41 def main():
40 parser = optparse.OptionParser() 42 parser = optparse.OptionParser()
41 parser.add_option('--libraries-top-dir', 43 parser.add_option('--libraries-top-dir',
42 help='Top directory that contains libraries ' 44 help='Top directory that contains libraries '
43 '(i.e. library paths are like ' 45 '(i.e. library paths are like '
44 'libraries_top_dir/lib/android_app_abi/foo.so).') 46 'libraries_top_dir/lib/android_app_abi/foo.so).')
45 parser.add_option('--input-apk-path', help='Path to incomplete APK.') 47 parser.add_option('--input-apk-path', help='Path to incomplete APK.')
46 parser.add_option('--output-apk-path', help='Path for standalone APK.') 48 parser.add_option('--output-apk-path', help='Path for standalone APK.')
47 parser.add_option('--stamp', help='Path to touch on success.') 49 parser.add_option('--stamp', help='Path to touch on success.')
48 options, _ = parser.parse_args() 50 options, _ = parser.parse_args()
49 51
50 required_options = ['libraries_top_dir', 'input_apk_path', 'output_apk_path'] 52 required_options = ['libraries_top_dir', 'input_apk_path', 'output_apk_path']
51 build_utils.CheckOptions(options, parser, required=required_options) 53 build_utils.CheckOptions(options, parser, required=required_options)
52 54
53 CreateStandaloneApk(options) 55 CreateStandaloneApk(options)
54 56
55 if options.stamp: 57 if options.stamp:
56 build_utils.Touch(options.stamp) 58 build_utils.Touch(options.stamp)
57 59
58 60
59 if __name__ == '__main__': 61 if __name__ == '__main__':
60 sys.exit(main(sys.argv)) 62 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/gyp/create_native_libraries_header.py ('k') | build/android/gyp/dex.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698