Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: build/android/lighttpd_server.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/install_emulator_deps.py ('k') | build/android/lint/suppress.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/lighttpd_server.py
diff --git a/build/android/lighttpd_server.py b/build/android/lighttpd_server.py
index 11ae794d4ade6a9d7fdbbbb286b8e724377f26fb..a5195ac815e7611c6da7717b83dede635cfc6221 100755
--- a/build/android/lighttpd_server.py
+++ b/build/android/lighttpd_server.py
@@ -64,7 +64,8 @@ class LighttpdServer(object):
def _Mktmp(self, name):
return os.path.join(self.temp_dir, name)
- def _GetRandomPort(self):
+ @staticmethod
+ def _GetRandomPort():
# The ports of test server is arranged in constants.py.
return random.randint(constants.LIGHTTPD_RANDOM_PORT_FIRST,
constants.LIGHTTPD_RANDOM_PORT_LAST)
@@ -145,7 +146,8 @@ class LighttpdServer(object):
break
return (client_error or 'Timeout', server_msg)
- def _KillProcessListeningOnPort(self, port):
+ @staticmethod
+ def _KillProcessListeningOnPort(port):
"""Checks if there is a process listening on port number |port| and
terminates it if found.
@@ -158,7 +160,8 @@ class LighttpdServer(object):
assert subprocess.call(['fuser', '-v', '%d/tcp' % port]) != 0, \
'Unable to kill process listening on port %d.' % port
- def _GetDefaultBaseConfig(self):
+ @staticmethod
+ def _GetDefaultBaseConfig():
return """server.tag = "%(server_tag)s"
server.modules = ( "mod_access",
"mod_accesslog",
« no previous file with comments | « build/android/install_emulator_deps.py ('k') | build/android/lint/suppress.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698